Skip to content

Fix flags in apple_common.cmake #11516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 10, 2025
Merged

Fix flags in apple_common.cmake #11516

merged 1 commit into from
Jun 10, 2025

Conversation

shoumikhin
Copy link
Contributor

No description provided.

@shoumikhin
Fix flags in apple_common.cmake
0fc3a49 
Cmake merges both flags into a single string otherwise, and overall, we don't need them
@shoumikhin shoumikhin added the release notes: none Do not include this in the release notes label Jun 10, 2025
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jun 10, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11516

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit 0fc3a49 with merge base 18e9149 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 10, 2025
@shoumikhin shoumikhin merged commit 120eb85 into main Jun 10, 2025
192 of 194 checks passed
@shoumikhin shoumikhin deleted the shoumikhin-patch-1 branch June 10, 2025 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jathu jathu jathu approved these changes

@larryliu0820 larryliu0820 Awaiting requested review from larryliu0820 larryliu0820 is a code owner

@kirklandsign kirklandsign Awaiting requested review from kirklandsign kirklandsign is a code owner

Assignees
No one assigned
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: none Do not include this in the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shoumikhin @jathu @mergennachin @facebook-github-bot