Skip to content

Conversation

guangy10
Copy link
Contributor

Summary

As we added support to run HF models in our apps, we should ignore adding/showing HF specific artifacts in our repo. For example, when drop in the tokenizer.json to the resource dir in iOS app:

Untracked files:
  (use "git add <file>..." to include in what will be committed)
	extension/benchmark/apple/Benchmark/Resources/tokenizer.json

@guangy10 guangy10 requested a review from shoumikhin June 12, 2025 18:12
Copy link

pytorch-bot bot commented Jun 12, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11609

Note: Links to docs will display an error until the docs builds have been completed.

❌ 17 New Failures, 3 Pending, 51 Unrelated Failures

As of commit 0ff404f with merge base f3a6c18 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 12, 2025
@guangy10 guangy10 added the release notes: none Do not include this in the release notes label Jun 12, 2025
@guangy10 guangy10 marked this pull request as ready for review June 12, 2025 18:12
@guangy10 guangy10 merged commit 30582ab into main Jun 12, 2025
27 of 98 checks passed
@guangy10 guangy10 deleted the gitignore_export_artifacts branch June 12, 2025 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants