Use PAL table override for pybinding log routing #11616
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GregoryComer
requested review from
JacobSzwejbka and
larryliu0820
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11616
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit cfc35c8 with merge base df4c12e ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D74122422 |
GregoryComer
added
the
release notes: none
Summary: This PR updates the pybinding log routing to use the new PAL table overrides to reliably route logs. Previously, the PAL is not overridden in optimized bento kernels, preventing users from seeing logs. Differential Revision: D74122422
GregoryComer
force-pushed
the
export-D74122422
branch
from
b1bbcbc to
cfc35c8
Compare
|
@GregoryComer has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
larryliu0820
approved these changes
Jun 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This PR updates the pybinding log routing to use the new PAL table overrides to reliably route logs. Previously, the PAL is not overridden in optimized bento kernels, preventing users from seeing logs.
Differential Revision: D74122422