Skip to content

Conversation

psiddh
Copy link
Contributor

@psiddh psiddh commented Jun 13, 2025

  • Explicitly specify paths to FVP simulator with different examples / usages

Summary

[PLEASE REMOVE] See CONTRIBUTING.md's Pull Requests for ExecuTorch PR guidelines.

[PLEASE REMOVE] If this PR closes an issue, please add a Fixes #<issue-id> line.

[PLEASE REMOVE] If this PR introduces a fix or feature that should be the upcoming release notes, please add a "Release notes: " label. For a list of available release notes labels, check out CONTRIBUTING.md's Pull Requests.

Test plan

[PLEASE REMOVE] How did you test this PR? Please write down any manual commands you used and note down tests that you have written if applicable.

- Fix paths to FVP simulator path
@psiddh psiddh requested a review from mergennachin as a code owner June 13, 2025 00:59
Copy link

pytorch-bot bot commented Jun 13, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11625

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit ea57693 with merge base d719e8e (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 13, 2025
@psiddh psiddh requested review from digantdesai, larryliu0820, lucylq and mergennachin and removed request for mergennachin June 13, 2025 00:59
@psiddh psiddh added the release notes: none Do not include this in the release notes label Jun 13, 2025
Copy link
Contributor

@larryliu0820 larryliu0820 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@psiddh psiddh merged commit 4a9952e into pytorch:main Jun 13, 2025
96 of 98 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants