Arm backend: Fix warnings from cppcheck in runtime

[perheld]

The runtime is written in C++ and had a bunch of cstyle castings and mixed operator tokens. This commit addresses these warnings.

Signed-off-by: per.held@arm.com

Change-Id: I8fa9d36ce61c98896b56b2db920d9d2db9fe972e

cc @larryliu0820 @JacobSzwejbka @lucylq @digantdesai @freddan80 @per @zingo @oscarandersson8218

[pytorch-bot]

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11639

• 📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 2 Pending, 3 Unrelated Failures

As of commit 34685d4 with merge base d9b3cf4 ():

NEW FAILURE - The following job has failed:

• trunk / unittest-nxp-neutron / linux-job (gh)
  RuntimeError: Command docker exec -t 949d973c33c7de48086d2d0a68e9914164c86742a0b64d122e024be60079435b /exec failed with exit code 1

FLAKY - The following job failed but was likely due to flakiness present on trunk:

• trunk / unittest-release / linux / linux-job (gh) (similar failure)
  /pytorch/executorch/backends/vulkan/runtime/api/containers/Tensor.cpp:651:17: error: no matching constructor for initialization of 'vkcompute::api::vTensor::TextureLimits'

BROKEN TRUNK - The following jobs failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

• pull / unittest / linux / linux-job (gh) (trunk failure)
  /pytorch/executorch/backends/vulkan/runtime/api/containers/Tensor.cpp:651:17: error: no matching constructor for initialization of 'vkcompute::api::vTensor::TextureLimits'
• pull / unittest-editable / linux / linux-job (gh) (trunk failure)
  /pytorch/executorch/backends/vulkan/runtime/api/containers/Tensor.cpp:651:17: error: no matching constructor for initialization of 'vkcompute::api::vTensor::TextureLimits'

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[zingo]

Tests broken on main also