Skip to content

Use MAP_SHARED to allow sharing memory between processing #11733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 18, 2025
Merged

Use MAP_SHARED to allow sharing memory between processing #11733

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5e4b2f1
Use MAP_SHARED to allow sharing memory between processing
shoumikhin Jun 16, 2025
683fa14
Merge branch 'main' into shoumikhin-patch-2
shoumikhin Jun 16, 2025
8c89e8f
Merge branch 'main' into shoumikhin-patch-2
shoumikhin Jun 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions extension/data_loader/mmap_data_loader.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,14 +193,13 @@ Result<FreeableBuffer> MmapDataLoader::load(
map_size = file_size_ - range.start;
}

// Map the pages read-only. MAP_PRIVATE vs. MAP_SHARED doesn't matter since
// the data is read-only, but use PRIVATE just to further avoid accidentally
// modifying the file.
// Map the pages read-only. Use shared mappings so that other processes
// can also map the same pages and share the same memory.
void* pages = ::mmap(
nullptr,
map_size,
PROT_READ,
MAP_PRIVATE,
MAP_SHARED,
fd_,
static_cast<off_t>(range.start));
ET_CHECK_OR_RETURN_ERROR(
Expand Down
Loading