Skip to content

Conversation

guangy10
Copy link
Contributor

Summary

Running install_dev.py for optimum-executorch will force overriding installed executorch and torch deps to the pinned nightly in optimum-executorch. In ExecuTorch CI including the benchmark, we would want to always run the optimum-executorch models with ExecuTorch from source to catch issues/regressions.

Test plan

Verified the installed deps in the CI and benchmark jobs

Copy link

pytorch-bot bot commented Jun 17, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11745

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 84dad53 with merge base 7b39a0c (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 17, 2025
@guangy10 guangy10 added release notes: none Do not include this in the release notes and removed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Jun 17, 2025
@guangy10 guangy10 requested review from huydhn and kimishpatel June 17, 2025 00:57
@guangy10 guangy10 temporarily deployed to upload-benchmark-results June 17, 2025 01:36 — with GitHub Actions Inactive
@guangy10 guangy10 temporarily deployed to upload-benchmark-results June 17, 2025 01:51 — with GitHub Actions Inactive
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 17, 2025
Copy link
Contributor

@huydhn huydhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, good catch!

@guangy10 guangy10 merged commit 20ea230 into main Jun 17, 2025
115 of 118 checks passed
@guangy10 guangy10 deleted the optimum_et_ci_installation branch June 17, 2025 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants