Skip to content

Arm backend: Add sinh decomposition pass and test #11848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 25, 2025
Merged

Arm backend: Add sinh decomposition pass and test #11848

merged 1 commit into from
Jun 25, 2025

Conversation

tbergkvist
Copy link
Contributor

@tbergkvist tbergkvist commented Jun 23, 2025 •
edited by pytorch-bot bot
Loading

Decomposes sinh into other operators/lookup table for MI/BI case.

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

@tbergkvist tbergkvist requested a review from digantdesai as a code owner June 23, 2025 08:24
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jun 23, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11848

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (3 Unrelated Failures)

As of commit 93815ec with merge base 7ede6be (image):

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

Hi @tbergkvist!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@zingo zingo added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: arm Changes to the ARM backend delegate ciflow/trunk labels Jun 23, 2025
@zingo
Copy link
Collaborator

zingo commented Jun 23, 2025 •
edited
Loading

Nice work!
This seem to have got a merge confict in
arm_pass_manager.py
thats needs to be adressed :(

Arm backend: Add sinh decomposition pass and test
93815ec 
Decomposes sinh into other operators/lookup table for MI/BI case.

Change-Id: I11f6e3c36a252f49813cba4dd03ec9e582d01de5
Signed-off-by: Teo Bergkvist <teo.bergkvist@arm.com>
Signed-off-by: Emma Kujala <emma.kujala@arm.com>
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 24, 2025
@tbergkvist tbergkvist force-pushed the Add-sinh-decomposition-pass-and-test branch from bfc5412 to 93815ec Compare June 25, 2025 06:33
oscarandersson8218
oscarandersson8218 approved these changes Jun 25, 2025
View reviewed changes
Copy link
Collaborator

@oscarandersson8218 oscarandersson8218 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@zingo zingo merged commit bbfcc2a into pytorch:main Jun 25, 2025
350 of 360 checks passed
hinriksnaer pushed a commit to hinriksnaer/executorch that referenced this pull request Jun 26, 2025
@tbergkvist @hinriksnaer
Arm backend: Add sinh decomposition pass and test (pytorch#11848)
33289f8 
Decomposes sinh into other operators/lookup table for MI/BI case.

Signed-off-by: Teo Bergkvist <teo.bergkvist@arm.com>
Signed-off-by: Emma Kujala <emma.kujala@arm.com>
@tbergkvist tbergkvist deleted the Add-sinh-decomposition-pass-and-test branch July 2, 2025 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oscarandersson8218 oscarandersson8218 oscarandersson8218 approved these changes

@digantdesai digantdesai Awaiting requested review from digantdesai digantdesai is a code owner

Assignees

No one assigned

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: arm Changes to the ARM backend delegate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tbergkvist @facebook-github-bot @zingo @oscarandersson8218