Fix shadowing error in mmap_data_loader.cpp #11858
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11858
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 70 PendingAs of commit 01066b4 with merge base 18e4240 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
This PR needs a
|
JacobSzwejbka
approved these changes
Jun 23, 2025
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Jun 24, 2025
This reverts commit da36d8a.
GregoryComer
added a commit
that referenced
this pull request
Jun 24, 2025
hinriksnaer
pushed a commit
to hinriksnaer/executorch
that referenced
this pull request
Jun 26, 2025
### Summary Fix a -Wshadow error causing internal build failures. I will add this to the GitHub CI, as well. ### Test plan CI
hinriksnaer
pushed a commit
to hinriksnaer/executorch
that referenced
this pull request
Jun 26, 2025
### Summary Revert pytorch#11654 and pytorch#11858 due to Meta-internal build breakage. I will re-land these (preserving attribution).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix a -Wshadow error causing internal build failures. I will add this to the GitHub CI, as well.
Test plan
CI