Add SNR numerical comparator #11859
Merged
Add SNR numerical comparator #11859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This PR introduces the SNR (Signal-to-Noise Ratio) comparator class, which extends the numerical comparison framework to evaluate model accuracy by comparing the SNR between two inputs. The comparator calculates the signal power and noise power from the two inputs, then computes the SNR using the formula SNR = 10 * log10(original_power / error_power). Differential Revision: D77159515
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11859
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 6616c6f with merge base 7f2fcb0 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D77159515 |
Gasoonjia
approved these changes
Jun 23, 2025
|
@pytorchbot label "release notes: none" |
pytorch-bot
bot
added
the
release notes: none
hinriksnaer
pushed a commit
to hinriksnaer/executorch
that referenced
this pull request
Jun 26, 2025
Differential Revision: D77159515 Pull Request resolved: pytorch#11859
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This PR introduces the SNR (Signal-to-Noise Ratio) comparator class, which extends the numerical comparison framework to evaluate model accuracy by comparing the SNR between two inputs. The comparator calculates the signal power and noise power from the two inputs, then computes the SNR using the formula SNR = 10 * log10(original_power / error_power).
Differential Revision: D77159515