Reland "Implement load_into for Mmap Data Loader" #11935
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11935
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 1 PendingAs of commit 5815291 with merge base 91c9ffa ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
### Summary - Adds `load_into()` to support memory mapped loading directly into the caller's buffer. - Enables copying a specific byte range from the file without creating an internal buffer. - Resuses input validation from `load()`. Fixes pytorch#11561 ### Test plan - Added unit tests to `MmapDataLoaderTest` for `load_into()` to validate copying for both aligned and offset data. - All Mmap Data Loader tests pass via: ``` ./build-ninja/extension/data_loader/test/extension_data_loader_test --gtest_filter='MmapDataLoaderTest.*' ``` - Full set of Data Loader tests pass via: ``` ./build-ninja/extension/data_loader/test/extension_data_loader_test ```
GregoryComer
force-pushed
the
reland-mmap-loader-changes
branch
from
1aac118 to
5815291
Compare
GregoryComer
added
the
release notes: none
JacobSzwejbka
approved these changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#11654 was reverted in #11928 due to a Meta-internal build breakage. This PR re-lands the changes along with a fix for the variable name shadowing. I will update OSS CI to run with -Wshadow enabled as a follow-up to catch this in GitHub in the future.