[llm] Route generate_from_pos() JNI API to native llm runner API #11952
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11952
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 1 New FailureAs of commit f311962 with merge base 5335eeb ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
mergennachin
approved these changes
Jun 26, 2025
larryliu0820
added a commit
that referenced
this pull request
Jun 27, 2025
Summary: Fix the issue on #11952 where we are missing a return in generate_from_pos() Reviewed By: GregoryComer Differential Revision: D77456146
larryliu0820
added a commit
that referenced
this pull request
Jun 27, 2025
Fix the issue on #11952 where we are missing a return in generate_from_pos()
larryliu0820
added a commit
that referenced
this pull request
Jun 27, 2025
Summary: Fix the issue on #11952 where we are missing a return in generate_from_pos() Reviewed By: GregoryComer Differential Revision: D77456146
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connect
generate_from_pos()API to C++ llm runner'sgenerate_from_pos().