Skip to content

Fix test_llm_config #11977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2025
Merged

Fix test_llm_config #11977

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions examples/models/llama/config/test_llm_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ def test_local_global_attention_without_kv(self):

def test_invalid_export_config_context_length(self):
with self.assertRaises(ValueError):
ExportConfig(max_seq_length=128, max_context_length=256)
ExportConfig(max_seq_length=256, max_context_length=128)

def test_invalid_qmode(self):
with self.assertRaises(ValueError):
Expand Down Expand Up @@ -84,8 +84,8 @@ def test_valid_llm_config(self):
local_global_attention="[16, 32]",
),
export=ExportConfig(
max_seq_length=256,
max_context_length=128,
max_seq_length=128,
max_context_length=256,
output_dir="/tmp/export",
output_name="model.pte",
),
Expand All @@ -94,7 +94,7 @@ def test_valid_llm_config(self):
backend=BackendConfig(
xnnpack=XNNPackConfig(enabled=False),
coreml=CoreMLConfig(
enabled=True, ios=17, compute_units=CoreMLComputeUnit.ALL
enabled=True, ios=17, compute_units=CoreMLComputeUnit.cpu_only
),
),
)
Expand Down
4 changes: 2 additions & 2 deletions extension/llm/export/test/test_export_llm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ def test_with_config(self, mock_export_llama: MagicMock) -> None:
model:
dtype_override: fp16
export:
max_seq_length: 256
max_seq_length: 128
quantization:
pt2e_quantize: xnnpack_dynamic
use_spin_quant: cuda
Expand All @@ -93,7 +93,7 @@ def test_with_config(self, mock_export_llama: MagicMock) -> None:
self.assertEqual(called_config.base.model_class, "llama2")
self.assertEqual(called_config.base.preq_mode.value, "8da4w")
self.assertEqual(called_config.model.dtype_override.value, "fp16")
self.assertEqual(called_config.export.max_seq_length, 256)
self.assertEqual(called_config.export.max_seq_length, 128)
self.assertEqual(
called_config.quantization.pt2e_quantize.value, "xnnpack_dynamic"
)
Expand Down
1 change: 1 addition & 0 deletions pytest.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ addopts =
--ignore=devtools/visualization/visualization_utils_test.py
# examples
examples/models/llama/tests
examples/models/llama/config
examples/models/llama3_2_vision/preprocess
examples/models/llama3_2_vision/vision_encoder/test
examples/models/llama3_2_vision/text_decoder/test
Expand Down
Loading