Prim ops replace abort with error code #11985
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11985
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit bd272f6 with merge base 9c9f665 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
@pytorchbot label "release notes: none" |
pytorch-bot
bot
added
the
release notes: none
lucylq
reviewed
Jun 26, 2025
| ET_CHECK_MSG(false, "%zu, %zu", (size_t)a.tag, (size_t)b.tag); \ | ||
| #define __ET_PRIM_OP_ERROR_IMPL(a, b, context) \ | ||
| else { \ | ||
| ET_KERNEL_CHECK(context, false, InvalidType, /* void */); \ |
There was a problem hiding this comment.
Could we use ET_KERNEL_CHECK_MSG to keep the format string/error message?
e.g.
ET_KERNEL_CHECK_MSG(context, false, InvalidType, "%zu, %zu", (size_t)a.tag, (size_t)b.tag);
lucylq
reviewed
Jun 26, 2025
| // Try to negate a tensor, which should cause a runtime error. | ||
| ET_EXPECT_DEATH(getOpsFn("executorch_prim::neg.Scalar")(context_, stack), ""); | ||
| ET_EXPECT_KERNEL_FAILURE( | ||
| context_, |
There was a problem hiding this comment.
Linter failure here - can you try run lintrunner -a?
See: https://github.com/pytorch/executorch/blob/main/CONTRIBUTING.md#lintrunner
lucylq
approved these changes
Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We want to minimize the scenarios where ET fails fatally. If we need to check a precondition inside a kernel rather then calling ET_CHECK which internally dispatches to ABORT we should call ET_KERNEL_CHECK which sets an error state and returns.
Test plan
Replaced TestNegScalarWithTensorDies with TestNegScalarWithTensorFails. Before, it would expect an abort when negating a tensor. The new test expects a failure state instead.
The test can be run with
test/run_oss_cpp_tests.sh