Add Pybindings for Program.h/cpp #12016
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12016
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit fa7e447 with merge base 3ba0466 ( BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D77388495 |
|
@Conarnar has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Conarnar
changed the title
|
@pytorchbot label "release notes: none" |
pytorch-bot
bot
added
the
release notes: none
|
@Conarnar has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
lucylq
reviewed
Jul 1, 2025
JacobSzwejbka
approved these changes
Jul 1, 2025
Conarnar
force-pushed
the
export-D77388495
branch
from
7454544 to
9b95924
Compare
Conarnar
added a commit
to Conarnar/executorch
that referenced
this pull request
Jul 1, 2025
Summary: Today our python apis in executorch.runtime are implemented off of extension/pybindings which only offers a module api. We would like to migrate to having the lower level ET api exposed to python directly and then writing the module api in python. The first step to this is adding pybindings for Program. Bindings for the class Program and its methods num_methods and get_method_name were added. Test Plan: Tests were added to `extension/pybindings/test/make_test.py` 1. test_program_methods_one -- verifies num_methods and get_method_name works with one method 2. test_program_methods_multi -- verifies num_methods and get_method_name works with multiple methods 3. test_program_method_index_out_of_bounds -- verifies get_method_name raises a runtime error if index is out of bounds Rollback Plan: Reviewed By: JacobSzwejbka Differential Revision: D77388495 Pulled By: Conarnar
|
This pull request was exported from Phabricator. Differential Revision: D77388495 |
Summary: Today our python apis in executorch.runtime are implemented off of extension/pybindings which only offers a module api. We would like to migrate to having the lower level ET api exposed to python directly and then writing the module api in python. The first step to this is adding pybindings for Program. Bindings for the class Program and its methods num_methods and get_method_name were added. Test Plan: Tests were added to `extension/pybindings/test/make_test.py` 1. test_program_methods_one -- verifies num_methods and get_method_name works with one method 2. test_program_methods_multi -- verifies num_methods and get_method_name works with multiple methods 3. test_program_method_index_out_of_bounds -- verifies get_method_name raises a runtime error if index is out of bounds Rollback Plan: Reviewed By: JacobSzwejbka Differential Revision: D77388495 Pulled By: Conarnar
Conarnar
force-pushed
the
export-D77388495
branch
from
9b95924 to
fa7e447
Compare
|
This pull request was exported from Phabricator. Differential Revision: D77388495 |
BujSet
pushed a commit
to BujSet/executorch
that referenced
this pull request
Jul 2, 2025
Differential Revision: D77388495 Pull Request resolved: pytorch#12016
Tanish2101
pushed a commit
to Tanish2101/executorch
that referenced
this pull request
Jul 9, 2025
Differential Revision: D77388495 Pull Request resolved: pytorch#12016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Today our python apis in executorch.runtime are implemented off of extension/pybindings which only offers a module api. We would like to migrate to having the lower level ET api exposed to python directly and then writing the module api in python. The first step to this is adding pybindings for Program.
Bindings for the class Program and its methods num_methods and get_method_name were added.
Test plan
Tests were added to
extension/pybindings/test/make_test.py