Arm backend: Make sure we tests correctly with and without Corstone FVP #12108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zingo Andersen <zingo.andersen@arm.com> Change-Id: Id94e690361f08c97428c886c51b086582c2b516d
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12108
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 956cc41 with merge base 5d2193f ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
zingo
added
partner: arm
oscarandersson8218
approved these changes
Jul 1, 2025
Tanish2101
pushed a commit
to Tanish2101/executorch
that referenced
this pull request
Jul 9, 2025
…VP (pytorch#12108) ### Summary If the elf for running pytest with Corstone FVP exists pytests will pick it up and run with it. This change make sure to remove the elf for the FVP tests if it exists in the none FVP tests before running the tests. As it is (already) build in the FVP versions of the tests, this fix a problem that if you run the test after each other the non FVP tests could find the elf and run on the FVP even if it was not supposed to. ### Test plan GitHub and local verification. cc @digantdesai @freddan80 @per @oscarandersson8218 Signed-off-by: Zingo Andersen <zingo.andersen@arm.com>
zingo
deleted the
Arm-backend-Make-sure-we-tests-correctly-with-and-without-Corstone-FVP
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If the elf for running pytest with Corstone FVP exists pytests will pick it up and run with it. This change make sure to remove the elf for the FVP tests if it exists in the none FVP tests before running the tests. As it is (already) build in the FVP versions of the tests, this fix a problem that if you run the test after each other the non FVP tests could find the elf and run on the FVP even if it was not supposed to.
Test plan
GitHub and local verification.
cc @digantdesai @freddan80 @per @oscarandersson8218