Remove _skip_type_promotion config #12149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Stack from ghstack (oldest at bottom): |
swolchok
requested review from
JacobSzwejbka,
cccclai,
jackzhxng,
kirklandsign,
larryliu0820,
mergennachin and
metascroy
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12149
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 2 Cancelled JobsAs of commit b9c5a51 with merge base 967cfae ( NEW FAILURE - The following job has failed:
CANCELLED JOBS - The following jobs were cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
larryliu0820
approved these changes
Jul 1, 2025
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 2, 2025
Summary: I don't think we need this any more, assuming tests pass. It starts with an underscore, so it's private, so we can just remove it, right? Differential Revision: D77619493 Pulled By: swolchok
facebook-github-bot
force-pushed
the
gh/swolchok/489/head
branch
from
2f2080b to
ceb3459
Compare
|
This pull request was exported from Phabricator. Differential Revision: D77619493 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 2, 2025
Summary: I don't think we need this any more, assuming tests pass. It starts with an underscore, so it's private, so we can just remove it, right? Reviewed By: larryliu0820 Differential Revision: D77619493 Pulled By: swolchok
facebook-github-bot
force-pushed
the
gh/swolchok/489/head
branch
from
ceb3459 to
2ac4865
Compare
|
This pull request was exported from Phabricator. Differential Revision: D77619493 |
Summary: I don't think we need this any more, assuming tests pass. It starts with an underscore, so it's private, so we can just remove it, right? Reviewed By: larryliu0820 Differential Revision: D77619493 Pulled By: swolchok
facebook-github-bot
force-pushed
the
gh/swolchok/489/head
branch
from
2ac4865 to
b9c5a51
Compare
|
This pull request was exported from Phabricator. Differential Revision: D77619493 |
Tanish2101
pushed a commit
to Tanish2101/executorch
that referenced
this pull request
Jul 9, 2025
Differential Revision: D77619493 Pull Request resolved: pytorch#12149
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think we need this any more, assuming tests pass.
It starts with an underscore, so it's private, so we can just remove it, right?