-
Notifications
You must be signed in to change notification settings - Fork 646
Don't force extension_module to build as a shared library by default #12257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Stack from ghstack (oldest at bottom): |
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12257
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Unrelated FailureAs of commit c4a4bba with merge base 6c74651 ( NEW FAILURE - The following job has failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
hmm. the llava-runner build failure doesn't repro on Mac and I'm currently having internal-specific trouble building on my Linux machine. |
OK I've reproed on Linux. |
[ghstack-poisoned]
Other targets seem to just use whatever the default configuration is. Make this one work the same.