update the validity rule for regenerated stride from dim order #12280
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12280
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Unrelated FailureAs of commit a89e9ea with merge base 14085eb ( NEW FAILURE - The following job has failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D77759383 |
This PR needs a
|
…ch#12280) Summary: the strides used in the runtime is regenerated from dim order, we need to make sure the regenerated dim order behaves the same as original one, rather than regenerated dim order is exactly the same as original one. This diff update the comparsion rule to reach the goal. Differential Revision: D77759383
Gasoonjia
force-pushed
the
export-D77759383
branch
from
19122f8 to
5b9ede7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D77759383 |
| EXPECT_EQ(tensor->size(1), 2); | ||
| EXPECT_EQ(tensor->size(2), 2); | ||
|
|
||
| // recalculated stride[0]t o 2 to meet ET's requirement while maintain the |
| EXPECT_EQ(tensor->const_data_ptr<float>()[0], 3); | ||
| } | ||
|
|
||
| TEST_F(TensorPtrMakerTest, FailedCreateTensorUsingFromBlobWithIleegalStrides) { |
…ch#12280) Summary: the strides used in the runtime is regenerated from dim order, we need to make sure the regenerated dim order behaves the same as original one, rather than regenerated dim order is exactly the same as original one. This diff update the comparsion rule to reach the goal. Reviewed By: larryliu0820 Differential Revision: D77759383
Gasoonjia
force-pushed
the
export-D77759383
branch
from
5b9ede7 to
a89e9ea
Compare
|
This pull request was exported from Phabricator. Differential Revision: D77759383 |
Differential Revision: D77759383 Pull Request resolved: pytorch#12280
Summary: the strides used in the runtime is regenerated from dim order, we need to make sure the regenerated dim order behaves the same as original one, rather than regenerated dim order is exactly the same as original one. This diff update the comparsion rule to reach the goal.
Differential Revision: D77759383