Skip to content

Fix bug in ReplaceMulTensorWithMulAndFullOpsPass. #12287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 9, 2025
Merged

Fix bug in ReplaceMulTensorWithMulAndFullOpsPass. #12287

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion backends/cadence/aot/replace_ops.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2329,7 +2329,7 @@ def call(self, graph_module: torch.fx.GraphModule) -> PassResult:
# Extract an argument to a separate full op.
with graph_module.graph.inserting_before(mul_node):
full_tensor = graph_module.graph.call_function(
exir_ops.edge.aten.full.default, args=([1], full_arg)
torch.ops.aten.full.default, args=([1], full_arg)
)
new_mul_node = graph_module.graph.call_function(
torch.ops.aten.mul.Tensor, args=(x_arg, full_tensor)
Expand Down Expand Up @@ -2449,4 +2449,5 @@ class CadenceReplaceOpsInGraph:
ReplaceAtenApproxGeluWithApproxGeluPass,
ReplaceSplitWithSlicePass,
ReplacePowWithMulPass,
ReplaceMulTensorWithMulAndFullOpsPass,
]
2 changes: 1 addition & 1 deletion backends/cadence/aot/tests/test_replace_ops_passes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1933,7 +1933,7 @@ def test_extract_mul_argument_to_full(
graph_after_passes,
expected_op_counts={
torch.ops.aten.mul.Tensor: 1,
exir_ops.edge.aten.full.default: 1,
torch.ops.aten.full.default: 1,
},
)
)
Expand Down
Loading