Skip to content

Conversation

psiddh
Copy link
Contributor

@psiddh psiddh commented Jul 9, 2025

…s CAST (#12243)"

This reverts commit 1315388.

Summary

[PLEASE REMOVE] See CONTRIBUTING.md's Pull Requests for ExecuTorch PR guidelines.

[PLEASE REMOVE] If this PR closes an issue, please add a Fixes #<issue-id> line.

[PLEASE REMOVE] If this PR introduces a fix or feature that should be the upcoming release notes, please add a "Release notes: " label. For a list of available release notes labels, check out CONTRIBUTING.md's Pull Requests.

Test plan

[PLEASE REMOVE] How did you test this PR? Please write down any manual commands you used and note down tests that you have written if applicable.

@psiddh psiddh requested a review from lucylq July 9, 2025 18:38
@psiddh psiddh requested a review from digantdesai as a code owner July 9, 2025 18:38
@pytorch-bot pytorch-bot bot added the ci-no-td label Jul 9, 2025
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 9, 2025
Copy link

pytorch-bot bot commented Jul 9, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12309

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 Cancelled Jobs, 6 Unrelated Failures

As of commit 02b8f58 with merge base defa089 (image):

CANCELLED JOBS - The following jobs were cancelled. Please retry:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@psiddh psiddh added the release notes: none Do not include this in the release notes label Jul 9, 2025
Copy link
Contributor

@lucylq lucylq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - could you tag the author as well?

Reverting as this is causing some internal failures and the codebase is going out of sync --> we can re-apply this, import to internal and then fix the issues before merging.

@psiddh
Copy link
Contributor Author

psiddh commented Jul 9, 2025

Reverting this change, as they are breaking the internal CI. Will add/merge this back once the forward fix is in place

@YufengShi-dudu @oscarandersson8218 @digantdesai @lucylq

@psiddh
Copy link
Contributor Author

psiddh commented Jul 9, 2025

(Not merging) Closing this PR @digantdesai pushed a forward fix : #12312

@psiddh psiddh closed this Jul 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-no-td CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants