-
Notifications
You must be signed in to change notification settings - Fork 685
Revert "Arm backend: Match fp32->int32 cast between pytorch and TOSA'… #12309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…s CAST (pytorch#12243)" This reverts commit 1315388.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12309
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 Cancelled Jobs, 6 Unrelated FailuresAs of commit 02b8f58 with merge base defa089 ( CANCELLED JOBS - The following jobs were cancelled. Please retry:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks - could you tag the author as well?
Reverting as this is causing some internal failures and the codebase is going out of sync --> we can re-apply this, import to internal and then fix the issues before merging.
Reverting this change, as they are breaking the internal CI. Will add/merge this back once the forward fix is in place |
(Not merging) Closing this PR @digantdesai pushed a forward fix : #12312 |
…s CAST (#12243)"
This reverts commit 1315388.
Summary
[PLEASE REMOVE] See CONTRIBUTING.md's Pull Requests for ExecuTorch PR guidelines.
[PLEASE REMOVE] If this PR closes an issue, please add a
Fixes #<issue-id>
line.[PLEASE REMOVE] If this PR introduces a fix or feature that should be the upcoming release notes, please add a "Release notes: " label. For a list of available release notes labels, check out CONTRIBUTING.md's Pull Requests.
Test plan
[PLEASE REMOVE] How did you test this PR? Please write down any manual commands you used and note down tests that you have written if applicable.