Skip to content

Arm backend: Create ethosu directory (#11849) #12338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 31, 2025
Merged

Arm backend: Create ethosu directory (#11849) #12338

merged 1 commit into from
Jul 31, 2025

Conversation

digantdesai
Copy link
Contributor

Summary:
Move EthosU related files to its own directory.

cc digantdesai freddan80 per zingo oscarandersson8218

Differential Revision: D77349641

Pulled By: digantdesai

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jul 10, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12338

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 4bc4d51 with merge base 5338708 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 10, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D77349641

@github-actions GitHub Actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@digantdesai digantdesai mentioned this pull request Jul 10, 2025
Closed
Sebastian-Larsson
Sebastian-Larsson reviewed Jul 15, 2025
View reviewed changes
backends/arm/test/TARGETS
deps = [
":common",
"//executorch/backends/xnnpack/test/tester:tester",
"//executorch/backends/arm:arm_partitioner",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any users left of arm_partitioner? What happens to tosa_backend, tosa_partitioner etc.?

We're planning to move those to separate directories just like with this change, but I'm still wondering about the implications here.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@digantdesai

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, so Arm partitioner is a target for all partitions -

executorch/backends/arm/TARGETS

Line 4 in 8da2ea6

name = "arm_partitioner",

Feel free to put up a PR for your refactor I can try to do the buck change.

In the future I do want to test this buck file in GH OSS CI to allow you to move fast and test your changes in OSS.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! The changes look good to me, do you need approval from someone else at Arm or how do we proceed here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve stamp? :-p

@digantdesai @facebook-github-bot
Arm backend: Create ethosu directory (pytorch#12338)
4bc4d51 
Summary:
Pull Request resolved: pytorch#12338

Move EthosU related files to its own directory.

cc digantdesai freddan80 per zingo oscarandersson8218

Differential Revision: D77349641
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D77349641

@facebook-github-bot facebook-github-bot merged commit 439bb6c into pytorch:main Jul 31, 2025
98 of 102 checks passed
agrima1304 pushed a commit to agrima1304/executorch that referenced this pull request Aug 26, 2025
@digantdesai @agrima1304
Arm backend: Create ethosu directory (pytorch#11849)
bb86f2f 
Differential Revision: D77349641

Pull Request resolved: pytorch#12338
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Sebastian-Larsson Sebastian-Larsson Sebastian-Larsson left review comments

@AdrianLundell AdrianLundell AdrianLundell approved these changes

@mergennachin mergennachin Awaiting requested review from mergennachin mergennachin is a code owner

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@digantdesai @facebook-github-bot @AdrianLundell @Sebastian-Larsson