Skip to content

Conversation

mcr229
Copy link
Contributor

@mcr229 mcr229 commented Jul 11, 2025

Summary: Source partitions aren't always reliable. There was model that I recently saw where cat nodes weren't being quantized(likely because they were derived from a different source partition). Moving towards checking all cat nodes should be more reliable

Differential Revision: D78138409

@mcr229 mcr229 requested a review from digantdesai as a code owner July 11, 2025 17:51
Copy link

pytorch-bot bot commented Jul 11, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12405

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (4 Unrelated Failures)

As of commit 0cbe197 with merge base 9591978 (image):

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 11, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78138409

Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

mcr229 added a commit to mcr229/executorch that referenced this pull request Jul 11, 2025
Summary:

Source partitions aren't always reliable. There was model that I recently saw where cat nodes weren't being quantized(likely because they were derived from a different source partition). Moving towards checking all cat nodes should be more reliable

Reviewed By: digantdesai

Differential Revision: D78138409
@mcr229 mcr229 force-pushed the export-D78138409 branch from ee15d55 to 19b4e8d Compare July 11, 2025 21:15
Summary:
Pull Request resolved: pytorch#12405

Source partitions aren't always reliable. There was model that I recently saw where cat nodes weren't being quantized(likely because they were derived from a different source partition). Moving towards checking all cat nodes should be more reliable

Reviewed By: digantdesai

Differential Revision: D78138409
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78138409

@mcr229 mcr229 force-pushed the export-D78138409 branch from 19b4e8d to 0cbe197 Compare July 11, 2025 21:20
@facebook-github-bot facebook-github-bot merged commit 3950872 into pytorch:main Jul 12, 2025
94 of 100 checks passed
@mcr229 mcr229 deleted the export-D78138409 branch July 25, 2025 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants