Fix cache_positions tensor size in TextLLMRunner #12478
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Huggingface causal LM forward convention, `cache_position` should have the same length as `input_ids`. The previous logic will allocate `cache_position` based on method metadata which by default is equal to the maximum length of this tensor (normally max context length). Now changing the logic to align the size of `cache_position` to `input_ids`. ghstack-source-id: d1b407c Pull Request resolved: #12476
pytorchbot
requested review from
jackzhxng,
larryliu0820,
mergennachin and
swolchok
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12478
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 980f44d with merge base 042eb1a ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
larryliu0820
approved these changes
Jul 15, 2025
|
@pytorchbot cherry-pick --onto release/0.7 -c fixnewfeature |
pytorchbot
added a commit
that referenced
this pull request
Jul 15, 2025
This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: #12476 by @larryliu0820 ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/larryliu0820/68/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/larryliu0820/68/head Merge bot PR base: https://github.com/pytorch/executorch/tree/main Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/larryliu0820/68/orig @diff-train-skip-merge Co-authored-by: Mengwei Liu <larryliu@meta.com> (cherry picked from commit aa44c06)
Cherry picking #12478The cherry pick PR is at #12479 and it is recommended to link a fixnewfeature cherry pick PR with an issue. The following tracker issues are updated: Details for Dev Infra teamRaised by workflow job |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was created by the merge bot to help merge the original PR into the main branch.
ghstack PR number: #12476 by @larryliu0820
^ Please use this as the source of truth for the PR details, comments, and reviews
ghstack PR base: https://github.com/pytorch/executorch/tree/gh/larryliu0820/68/base
ghstack PR head: https://github.com/pytorch/executorch/tree/gh/larryliu0820/68/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/main
Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/larryliu0820/68/orig
@diff-train-skip-merge