Skip to content

Clean cache between Apple builds #12563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 16, 2025
Merged

Clean cache between Apple builds #12563

merged 1 commit into from
Jul 16, 2025

Conversation

jathu
Copy link
Contributor

@jathu jathu commented Jul 16, 2025

Summary

In this diff, we clear the CMakeCache.txt between builds since we reuse the same build output for all the builds. Keeping the cache means that configuration between each build won't be reflected (i.e. #12469).

Test plan

CI

I also tested to ensure that EXECUTORCH_ENABLE_LOGGING is being properly set based on the build mode.

-- PLATFORM: OS64
-- CMAKE_BUILD_TYPE: Release
-- EXECUTORCH_ENABLE_LOGGING: OFF
-- ----------------------------------------------------
-- PLATFORM: OS64
-- CMAKE_BUILD_TYPE: Debug
-- EXECUTORCH_ENABLE_LOGGING: ON
-- ----------------------------------------------------
-- PLATFORM: SIMULATORARM64
-- CMAKE_BUILD_TYPE: Release
-- EXECUTORCH_ENABLE_LOGGING: OFF
-- ----------------------------------------------------
-- PLATFORM: SIMULATORARM64
-- CMAKE_BUILD_TYPE: Debug
-- EXECUTORCH_ENABLE_LOGGING: ON
-- ----------------------------------------------------
-- PLATFORM: MAC_ARM64
-- CMAKE_BUILD_TYPE: Release
-- EXECUTORCH_ENABLE_LOGGING: OFF
-- ----------------------------------------------------
-- PLATFORM: MAC_ARM64
-- CMAKE_BUILD_TYPE: Debug
-- EXECUTORCH_ENABLE_LOGGING: ON
-- ----------------------------------------------------

@jathu jathu requested a review from shoumikhin July 16, 2025 21:33
@jathu jathu added ciflow/trunk ciflow/binaries release notes: none Do not include this in the release notes labels Jul 16, 2025
Copy link

pytorch-bot bot commented Jul 16, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12563

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 13 Pending, 1 Unrelated Failure

As of commit 55a1658 with merge base 988435d (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 16, 2025
@jathu jathu marked this pull request as ready for review July 16, 2025 21:33
@shoumikhin shoumikhin merged commit f98273c into main Jul 16, 2025
216 of 222 checks passed
@shoumikhin shoumikhin deleted the jathu/apple-fresh branch July 16, 2025 22:23
lucylq pushed a commit that referenced this pull request Jul 17, 2025
### Summary

In this diff, we clear the CMakeCache.txt between builds since we reuse
the same build output for all the builds. Keeping the cache means that
configuration between each build won't be reflected (i.e.
#12469).

### Test plan
CI

I also tested to ensure that `EXECUTORCH_ENABLE_LOGGING` is being
properly set based on the build mode.

```
-- PLATFORM: OS64
-- CMAKE_BUILD_TYPE: Release
-- EXECUTORCH_ENABLE_LOGGING: OFF
-- ----------------------------------------------------
-- PLATFORM: OS64
-- CMAKE_BUILD_TYPE: Debug
-- EXECUTORCH_ENABLE_LOGGING: ON
-- ----------------------------------------------------
-- PLATFORM: SIMULATORARM64
-- CMAKE_BUILD_TYPE: Release
-- EXECUTORCH_ENABLE_LOGGING: OFF
-- ----------------------------------------------------
-- PLATFORM: SIMULATORARM64
-- CMAKE_BUILD_TYPE: Debug
-- EXECUTORCH_ENABLE_LOGGING: ON
-- ----------------------------------------------------
-- PLATFORM: MAC_ARM64
-- CMAKE_BUILD_TYPE: Release
-- EXECUTORCH_ENABLE_LOGGING: OFF
-- ----------------------------------------------------
-- PLATFORM: MAC_ARM64
-- CMAKE_BUILD_TYPE: Debug
-- EXECUTORCH_ENABLE_LOGGING: ON
-- ----------------------------------------------------
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/binaries ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: none Do not include this in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants