Skip to content

Name Correction op_full_like #12755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 23, 2025
Merged

Conversation

BujSet
Copy link
Contributor

@BujSet BujSet commented Jul 23, 2025

Summary

Operator and dtype selective build requires operator names to match operators in use. This changes corrects the name for full_like operator.

Test plan

OpenAI's whisper-tiny encoder model requires the full_like operator. Modified the examples/selective_build/test_selective_build.sh script to use the pte from this model. Model previous crashed with missing operator, but now completes without error. I.e. ran bash examples/selective_build/test_selective_build.sh cmake.

Copy link

pytorch-bot bot commented Jul 23, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12755

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 3 Pending

As of commit 16da0de with merge base bc0ad82 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 23, 2025
@BujSet BujSet requested a review from lucylq July 23, 2025 18:43
@BujSet BujSet self-assigned this Jul 23, 2025
@BujSet BujSet added ciflow/trunk ciflow/binaries/all Release PRs with this label will build wheels for all python versions labels Jul 23, 2025
@BujSet BujSet changed the title Correcting name for dtype selection matching Name Correction op_full_like Jul 23, 2025
@BujSet
Copy link
Contributor Author

BujSet commented Jul 23, 2025

@pytorchbot label "release notes: none"

@pytorch-bot pytorch-bot bot added the release notes: none Do not include this in the release notes label Jul 23, 2025
@BujSet BujSet marked this pull request as ready for review July 23, 2025 18:48
@BujSet BujSet merged commit 8eb8cd1 into pytorch:main Jul 23, 2025
291 of 485 checks passed
@BujSet BujSet deleted the op_full_like_name_correction branch July 23, 2025 22:11
Conarnar pushed a commit to Conarnar/executorch that referenced this pull request Jul 25, 2025
### Summary
Operator and dtype selective build requires operator names to match
operators in use. This changes corrects the name for `full_like`
operator.

### Test plan
OpenAI's whisper-tiny encoder model requires the full_like operator.
Modified the `examples/selective_build/test_selective_build.sh` script
to use the pte from this model. Model previous crashed with missing
operator, but now completes without error. I.e. ran `bash
examples/selective_build/test_selective_build.sh cmake`.
@BujSet BujSet mentioned this pull request Jul 27, 2025
BujSet added a commit that referenced this pull request Jul 28, 2025
### Summary

Operator and dtype selective build requires operator names to match
operators in use. This changes corrects the name for `mean` operator.
Change is similar to that in #12755.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/binaries/all Release PRs with this label will build wheels for all python versions ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: none Do not include this in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants