Make kernels/portable/cpu compatible with C++11/14/17/20 #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D48668113 |
5 similar comments
|
This pull request was exported from Phabricator. Differential Revision: D48668113 |
|
This pull request was exported from Phabricator. Differential Revision: D48668113 |
|
This pull request was exported from Phabricator. Differential Revision: D48668113 |
|
This pull request was exported from Phabricator. Differential Revision: D48668113 |
|
This pull request was exported from Phabricator. Differential Revision: D48668113 |
Summary: Tweak the core runtime code to build cleanly with C++11 as well as with more recent versions. This only covers non-test targets under //executorch/runtime, enough to build `:size_test`. While doing this I removed a bunch of `constexpr` from methods on `ArrayRef` and `string_view`, because C++11 was more strict about what's allowed in them. While they're useful on general-purpose implementations of those types, we never do static comparison of array or string instances, so it doesn't help us. Not worth the complexity of adding `#ifdef`s to change the behavior depending on the C++ version. A lot of the template changes deal with the lack of `<base>_t` templates in C++11. Most of them are of the form ``` template<class T> using BASE_t = typename BASE<T>::type; ``` so the fix was to inline that pattern: add `typename` to the front and `::type` to the end. Differential Revision: https://internalfb.com/D48665438 fbshipit-source-id: c39180091153e1283ffd0dda729812e2080dcd48
Summary: Pull Request resolved: #128 Tweak the portable kernels to build cleanly with C++11 as well as with more recent versions. This only covers non-test, non-aten targets under `//executorch/kernels/portable/cpu/...`. A lot of the template changes deal with the lack of <base>_t templates in C++11. Most of them are of the form ``` template<class T> using BASE_t = typename BASE<T>::type; ``` so the fix was to inline that pattern: add `typename` to the front and `::type` to the end. Reviewed By: digantdesai, kirklandsign Differential Revision: D48668113 fbshipit-source-id: 056fe6706e55c3d52cc1cc67abf593f72c05a9b6
|
This pull request was exported from Phabricator. Differential Revision: D48668113 |
|
This pull request has been merged in 70a7973. |
Gasoonjia
pushed a commit
that referenced
this pull request
Jul 30, 2024
* code beautification * debug info * debug * add missing args * typo * fix dtype check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Tweak the portable kernels to build cleanly with C++11 as well as with more recent versions. This only covers non-test, non-aten targets under
//executorch/kernels/portable/cpu/....A lot of the template changes deal with the lack of _t templates in C++11. Most of them are of the form
so the fix was to inline that pattern: add
typenameto the front and::typeto the end.Differential Revision: D48668113