Skip to content

Extend cat op for complex dtype #12894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 31, 2025
Merged

Extend cat op for complex dtype #12894

merged 1 commit into from
Jul 31, 2025

Conversation

pssrawat
Copy link
Contributor

Summary: Need complex cat op for live translation

Differential Revision: D78934592

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jul 28, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12894

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 847bade with merge base 574e109 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 28, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78934592

@pssrawat pssrawat added the release notes: none Do not include this in the release notes label Jul 28, 2025
pssrawat added a commit to pssrawat/executorch that referenced this pull request Jul 28, 2025
@pssrawat @facebook-github-bot
Extend cat op for complex dtype (pytorch#12894)
13e9e03 
Summary:

Need complex cat op for live translation

Differential Revision: D78934592
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78934592

pssrawat added a commit to pssrawat/executorch that referenced this pull request Jul 29, 2025
@pssrawat @facebook-github-bot
Extend cat op for complex dtype (pytorch#12894)
e33752e 
Summary:

Need complex cat op for live translation

Differential Revision: D78934592
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78934592

pssrawat added a commit to pssrawat/executorch that referenced this pull request Jul 29, 2025
@pssrawat @facebook-github-bot
Extend cat op for complex dtype (pytorch#12894)
753c4ad 
Summary:

Need complex cat op for live translation

Differential Revision: D78934592
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78934592

manuelcandales
manuelcandales reviewed Jul 29, 2025
View reviewed changes
kernels/portable/cpu/op_cat.cpp Outdated
executorch::runtime::isComplexType(out.scalar_type());

if (out_is_complex) {
// All the input tensors and output must have same dtype
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not a restriction of the ATen op. i.e. you can concat complex tensor of different dtype.
please add a TODO here, to allow mixed input dtype when output is complex.

@pssrawat @facebook-github-bot
Extend cat op for complex dtype (pytorch#12894)
847bade 
Summary:

Need complex cat op for live translation. The current support for complex dtype enforces that input and output tensors have the same dtype. Support mixed dtypes in the future.

Differential Revision: D78934592
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78934592

@pssrawat pssrawat requested a review from manuelcandales July 29, 2025 18:05
pssrawat added a commit to pssrawat/executorch that referenced this pull request Jul 29, 2025
@pssrawat @facebook-github-bot
Extend cat op for complex dtype (pytorch#12894)
ccef472 
Summary:

Need complex cat op for live translation. The current support for complex dtype enforces that input and output tensors have the same dtype. Support mixed dtypes in the future.

Differential Revision: D78934592
@facebook-github-bot facebook-github-bot merged commit 97699f1 into pytorch:main Jul 31, 2025
102 of 103 checks passed
agrima1304 pushed a commit to agrima1304/executorch that referenced this pull request Aug 26, 2025
@pssrawat @agrima1304
Extend cat op for complex dtype
1907d2f 
Differential Revision: D78934592

Pull Request resolved: pytorch#12894
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@manuelcandales manuelcandales manuelcandales approved these changes

@swolchok swolchok Awaiting requested review from swolchok swolchok is a code owner

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported release notes: none Do not include this in the release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pssrawat @facebook-github-bot @manuelcandales