Skip to content

Conversation

gggekov
Copy link
Collaborator

@gggekov gggekov commented Jul 29, 2025

This patch moves the portable kernels from the ITCM to the BRAM so that we don't overflow on the ITCM when linking the application

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

This patch moves the portable kernels from the ITCM to the BRAM
so that we don't overflow on the ITCM when linking the application

Change-Id: Ib6dd5fc97a0fa1138b7702cb23052a7015ff4135
@gggekov gggekov requested a review from digantdesai as a code owner July 29, 2025 10:01
Copy link

pytorch-bot bot commented Jul 29, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12955

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 51d8fbd with merge base b0dda93 (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 29, 2025
@gggekov gggekov added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk topic: not user facing labels Jul 29, 2025
Copy link
Contributor

@digantdesai digantdesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is OK. FWIW, we added PTE based dtype selective build, in addition to existing per op selective build to further reduce the size of these op_*_cpp.obj files :)

FYI @BujSet

@gggekov gggekov added the release notes: none Do not include this in the release notes label Jul 29, 2025
Copy link
Collaborator

@Sebastian-Larsson Sebastian-Larsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated CI errors. Approved

@Sebastian-Larsson Sebastian-Larsson merged commit 339e95f into pytorch:main Jul 29, 2025
214 of 216 checks passed
@digantdesai
Copy link
Contributor

@GeorgeARM do we need this also for CS320 for U85?

@gggekov
Copy link
Collaborator Author

gggekov commented Jul 30, 2025

On the CS320, the .text section is stored in the BRAM and we have 2MB of BRAM, so we haven't seen link time failures due to building with more portable kernels.
On the CS300, the .text section is in the ITCM and we have 512KB of ITCM, hence we saw link time errors on some models, that's why I've only changed the placement of the portable kernels for the CS300.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants