Arm backend: Do not partition noop subgraphs #12995
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdrianLundell
added
partner: arm
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12995
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 2 New Failures, 1 Unrelated FailureAs of commit b566bb6 with merge base f8a422c ( NEW FAILURES - The following jobs have failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
|
Need a rebase, sorry :( |
AdrianLundell
force-pushed
the
change-1078286
branch
from
99b47bb to
55aeae8
Compare
|
I'll wait with this PR until #12994 is merged |
- Reject partitions that will be lowered to empty subgraphs, i.e. containing only clones/ noop expands. - For eye/one/zeros the graph is not really empty since it contains one constant, which works after a Vela update. Simply move the previosuly xfailing tests to MI/BI. (u55/ u85 still fails because of missing CPU ops - this is why we missed when this started working) Signed-off-by: Adrian Lundell <adrian.lundell@arm.com> Change-Id: Iefa034a8e731d70465eb4883602c958f51aca976
AdrianLundell
force-pushed
the
change-1078286
branch
from
12f2928 to
b566bb6
Compare
AdrianLundell
changed the title
|
Failures unrelated I believe |
oscarandersson8218
approved these changes
Sep 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218