Skip to content

Update EVal Payload to use pointers for larger objects #13013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 1, 2025
Merged

Update EVal Payload to use pointers for larger objects #13013

merged 1 commit into from
Oct 1, 2025
+163 −96

Conversation

JakeStevens
Copy link
Contributor

Summary:
As noted in the comment, switching to ptrs in the union can save memory.

Specifically, the size of this object goes from 24 bytes -> 8 bytes.

In this diff, we move to pointers for some of the larger objects. When parsing the flatbuffer, we allocate memory from the method allocator and store this in the EVal. The get* functions then de-reference that pointer.

Differential Revision: D79286076

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jul 30, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13013

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 2 Unrelated Failures

As of commit 8cb13d7 with merge base 943e34a (image):

NEW FAILURE - The following job has failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following job failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 30, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D79286076

@github-actions GitHub Actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

JakeStevens added a commit to JakeStevens/executorch that referenced this pull request Sep 9, 2025
@JakeStevens @facebook-github-bot
Update EVal Payload to use pointers for larger objects (pytorch#13013)
09e3fd2 
Summary:

As noted in the comment, switching to ptrs in the union can save memory.

Specifically, the size of this object goes from 24 bytes -> 8 bytes.

In this diff, we move to pointers for some of the larger objects. When parsing the flatbuffer, we allocate memory from the method allocator and store this in the EVal. The get* functions then de-reference that pointer.

Differential Revision: D79286076
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D79286076

JakeStevens added a commit to JakeStevens/executorch that referenced this pull request Sep 23, 2025
@JakeStevens @facebook-github-bot
Update EVal Payload to use pointers for larger objects (pytorch#13013)
3e6e230 
Summary:

As noted in the comment, switching to ptrs in the union can save memory.

Specifically, the size of this object goes from 24 bytes -> 8 bytes.

In this diff, we move to pointers for some of the larger objects. When parsing the flatbuffer, we allocate memory from the method allocator and store this in the EVal. The get* functions then de-reference that pointer.

Differential Revision: D79286076
@facebook-github-bot
Copy link
Contributor

@JakeStevens has exported this pull request. If you are a Meta employee, you can view the originating diff in D79286076.

JakeStevens added a commit to JakeStevens/executorch that referenced this pull request Sep 24, 2025
@JakeStevens @facebook-github-bot
Update EVal Payload to use pointers for larger objects (pytorch#13013)
73022d4 
Summary:

As noted in the comment, switching to ptrs in the union can save memory.

Specifically, the size of this object goes from 24 bytes -> 8 bytes.

In this diff, we move to pointers for some of the larger objects. When parsing the flatbuffer, we allocate memory from the method allocator and store this in the EVal. The get* functions then de-reference that pointer.

Reviewed By: JacobSzwejbka

Differential Revision: D79286076
@facebook-github-bot
Copy link
Contributor

@JakeStevens has exported this pull request. If you are a Meta employee, you can view the originating diff in D79286076.

JakeStevens added a commit to JakeStevens/executorch that referenced this pull request Sep 24, 2025
@JakeStevens @facebook-github-bot
Update EVal Payload to use pointers for larger objects (pytorch#13013)
b3aacf8 
Summary:

As noted in the comment, switching to ptrs in the union can save memory.

Specifically, the size of this object goes from 24 bytes -> 8 bytes.

In this diff, we move to pointers for some of the larger objects. When parsing the flatbuffer, we allocate memory from the method allocator and store this in the EVal. The get* functions then de-reference that pointer.

Reviewed By: JacobSzwejbka

Differential Revision: D79286076
@facebook-github-bot
Copy link
Contributor

@JakeStevens has exported this pull request. If you are a Meta employee, you can view the originating diff in D79286076.

JakeStevens added a commit to JakeStevens/executorch that referenced this pull request Sep 24, 2025
@JakeStevens @facebook-github-bot
Update EVal Payload to use pointers for larger objects (pytorch#13013)
0cf2c1f 
Summary:

As noted in the comment, switching to ptrs in the union can save memory.

Specifically, the size of this object goes from 24 bytes -> 8 bytes.

In this diff, we move to pointers for some of the larger objects. When parsing the flatbuffer, we allocate memory from the method allocator and store this in the EVal. The get* functions then de-reference that pointer.

Reviewed By: JacobSzwejbka

Differential Revision: D79286076
@facebook-github-bot
Copy link
Contributor

@JakeStevens has exported this pull request. If you are a Meta employee, you can view the originating diff in D79286076.

@facebook-github-bot
Copy link
Contributor

@JakeStevens has exported this pull request. If you are a Meta employee, you can view the originating diff in D79286076.

JakeStevens added a commit to JakeStevens/executorch that referenced this pull request Sep 26, 2025
@JakeStevens @facebook-github-bot
Update EVal Payload to use pointers for larger objects (pytorch#13013)
bca2c72 
Summary:

As noted in the comment, switching to ptrs in the union can save memory.

Specifically, the size of this object goes from 24 bytes -> 8 bytes.

In this diff, we move to pointers for some of the larger objects. When parsing the flatbuffer, we allocate memory from the method allocator and store this in the EVal. The get* functions then de-reference that pointer.

Reviewed By: JacobSzwejbka

Differential Revision: D79286076
@facebook-github-bot
Copy link
Contributor

@JakeStevens has exported this pull request. If you are a Meta employee, you can view the originating diff in D79286076.

JakeStevens added a commit to JakeStevens/executorch that referenced this pull request Sep 29, 2025
@JakeStevens @facebook-github-bot
Update EVal Payload to use pointers for larger objects (pytorch#13013)
9ce413d 
Summary:

As noted in the comment, switching to ptrs in the union can save memory.

Specifically, the size of this object goes from 24 bytes -> 8 bytes.

In this diff, we move to pointers for some of the larger objects. When parsing the flatbuffer, we allocate memory from the method allocator and store this in the EVal. The get* functions then de-reference that pointer.

Reviewed By: JacobSzwejbka

Differential Revision: D79286076
@facebook-github-bot
Copy link
Contributor

@JakeStevens has exported this pull request. If you are a Meta employee, you can view the originating diff in D79286076.

JakeStevens added a commit to JakeStevens/executorch that referenced this pull request Sep 29, 2025
@JakeStevens @facebook-github-bot
Update EVal Payload to use pointers for larger objects (pytorch#13013)
ffbe082 
Summary:

As noted in the comment, switching to ptrs in the union can save memory.

Specifically, the size of this object goes from 24 bytes -> 8 bytes.

In this diff, we move to pointers for some of the larger objects. When parsing the flatbuffer, we allocate memory from the method allocator and store this in the EVal. The get* functions then de-reference that pointer.

Reviewed By: JacobSzwejbka

Differential Revision: D79286076
@facebook-github-bot
Copy link
Contributor

@JakeStevens has exported this pull request. If you are a Meta employee, you can view the originating diff in D79286076.

JakeStevens added a commit to JakeStevens/executorch that referenced this pull request Sep 30, 2025
@JakeStevens @facebook-github-bot
Update EVal Payload to use pointers for larger objects (pytorch#13013)
f07873e 
Summary:

As noted in the comment, switching to ptrs in the union can save memory.

Specifically, the size of this object goes from 24 bytes -> 8 bytes.

In this diff, we move to pointers for some of the larger objects. When parsing the flatbuffer, we allocate memory from the method allocator and store this in the EVal. The get* functions then de-reference that pointer.

Reviewed By: JacobSzwejbka

Differential Revision: D79286076
@facebook-github-bot
Copy link
Contributor

@JakeStevens has exported this pull request. If you are a Meta employee, you can view the originating diff in D79286076.

JakeStevens added a commit to JakeStevens/executorch that referenced this pull request Sep 30, 2025
@JakeStevens @facebook-github-bot
Update EVal Payload to use pointers for larger objects (pytorch#13013)
30c5bfe 
Summary:

As noted in the comment, switching to ptrs in the union can save memory.

Specifically, the size of this object goes from 24 bytes -> 8 bytes.

In this diff, we move to pointers for some of the larger objects. When parsing the flatbuffer, we allocate memory from the method allocator and store this in the EVal. The get* functions then de-reference that pointer.

Reviewed By: JacobSzwejbka

Differential Revision: D79286076
@facebook-github-bot
Copy link
Contributor

@JakeStevens has exported this pull request. If you are a Meta employee, you can view the originating diff in D79286076.

JakeStevens added a commit to JakeStevens/executorch that referenced this pull request Sep 30, 2025
@JakeStevens @facebook-github-bot
Update EVal Payload to use pointers for larger objects (pytorch#13013)
815079b 
Summary:

As noted in the comment, switching to ptrs in the union can save memory.

Specifically, the size of this object goes from 24 bytes -> 8 bytes.

In this diff, we move to pointers for some of the larger objects. When parsing the flatbuffer, we allocate memory from the method allocator and store this in the EVal. The get* functions then de-reference that pointer.

Reviewed By: JacobSzwejbka

Differential Revision: D79286076
@facebook-github-bot
Copy link
Contributor

@JakeStevens has exported this pull request. If you are a Meta employee, you can view the originating Diff in D79286076.

JakeStevens added a commit to JakeStevens/executorch that referenced this pull request Sep 30, 2025
@JakeStevens @facebook-github-bot
Update EVal Payload to use pointers for larger objects (pytorch#13013)
6240e19 
Summary:

As noted in the comment, switching to ptrs in the union can save memory.

Specifically, the size of this object goes from 24 bytes -> 8 bytes.

In this diff, we move to pointers for some of the larger objects. When parsing the flatbuffer, we allocate memory from the method allocator and store this in the EVal. The get* functions then de-reference that pointer.

Reviewed By: JacobSzwejbka

Differential Revision: D79286076
@facebook-github-bot
Copy link
Contributor

@JakeStevens has exported this pull request. If you are a Meta employee, you can view the originating Diff in D79286076.

JakeStevens added a commit to JakeStevens/executorch that referenced this pull request Sep 30, 2025
@JakeStevens @facebook-github-bot
Update EVal Payload to use pointers for larger objects (pytorch#13013)
669bc22 
Summary:

As noted in the comment, switching to ptrs in the union can save memory.

Specifically, the size of this object goes from 24 bytes -> 8 bytes.

In this diff, we move to pointers for some of the larger objects. When parsing the flatbuffer, we allocate memory from the method allocator and store this in the EVal. The get* functions then de-reference that pointer.

Reviewed By: JacobSzwejbka

Differential Revision: D79286076
@facebook-github-bot
Copy link
Contributor

@JakeStevens has exported this pull request. If you are a Meta employee, you can view the originating Diff in D79286076.

JakeStevens added a commit to JakeStevens/executorch that referenced this pull request Oct 1, 2025
@JakeStevens @facebook-github-bot
Update EVal Payload to use pointers for larger objects (pytorch#13013)
07b6f09 
Summary:

As noted in the comment, switching to ptrs in the union can save memory.

Specifically, the size of this object goes from 24 bytes -> 8 bytes.

In this diff, we move to pointers for some of the larger objects. When parsing the flatbuffer, we allocate memory from the method allocator and store this in the EVal. The get* functions then de-reference that pointer.

Reviewed By: JacobSzwejbka

Differential Revision: D79286076
@JakeStevens @facebook-github-bot
Update EVal Payload to use pointers for larger objects (pytorch#13013)
8cb13d7 
Summary:

As noted in the comment, switching to ptrs in the union can save memory.

Specifically, the size of this object goes from 24 bytes -> 8 bytes.

In this diff, we move to pointers for some of the larger objects. When parsing the flatbuffer, we allocate memory from the method allocator and store this in the EVal. The get* functions then de-reference that pointer.

Reviewed By: JacobSzwejbka

Differential Revision: D79286076
@facebook-github-bot facebook-github-bot merged commit b100c95 into pytorch:main Oct 1, 2025
127 of 133 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JacobSzwejbka JacobSzwejbka JacobSzwejbka approved these changes

@lucylq lucylq Awaiting requested review from lucylq lucylq is a code owner

@swolchok swolchok Awaiting requested review from swolchok swolchok is a code owner

@manuelcandales manuelcandales Awaiting requested review from manuelcandales manuelcandales is a code owner

@kimishpatel kimishpatel Awaiting requested review from kimishpatel kimishpatel is a code owner

@GregoryComer GregoryComer Awaiting requested review from GregoryComer GregoryComer is a code owner

@Gasoonjia Gasoonjia Awaiting requested review from Gasoonjia Gasoonjia is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JakeStevens @facebook-github-bot @JacobSzwejbka