Skip to content

Conversation

shewu-quic
Copy link
Collaborator

Summary:

  • Resolve the Whisper model accuracy issue caused by upgrading the Transformers.
    • Modify decompose_sdpa.py to support kwargs "scale"
  • fixed internal CI

cc: @haowhsu-quic , @winskuo-quic

Summary:
- Resolve the Whisper model  accuracy issue caused by upgrading the Transformers.
- Modify decompose_sdpa.py to support kwargs "scale"
- fixed internal CI
Copy link

pytorch-bot bot commented Aug 1, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13062

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 1 New Failure

As of commit 936997d with merge base 4197fc1 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 1, 2025
@shewu-quic
Copy link
Collaborator Author

Hi @cccclai,
This PR is to fixed the accuracy issue of the whisper model when upgrade transformers. The primary issue is that the original sdpa does not account for the "scale" keyword argument, which is now used by the latest Whisper model.
https://github.com/huggingface/transformers/blob/d3b8627b56caa7ca8fac113c9f28d0256db0194d/src/transformers/models/whisper/modeling_whisper.py#L358

@shewu-quic
Copy link
Collaborator Author

@pytorchbot label "release notes: qualcomm"

@pytorch-bot pytorch-bot bot added the release notes: qualcomm Changes to the Qualcomm backend delegate label Aug 1, 2025
@facebook-github-bot
Copy link
Contributor

@cccclai has imported this pull request. If you are a Meta employee, you can view this in D79457707.

Copy link
Contributor

@cccclai cccclai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cccclai cccclai merged commit cbbbc3a into pytorch:main Aug 4, 2025
103 of 106 checks passed
agrima1304 pushed a commit to agrima1304/executorch that referenced this pull request Aug 26, 2025
…rch#13062)

Summary:
- Resolve the Whisper model accuracy issue caused by upgrading the
Transformers.
  - Modify decompose_sdpa.py to support kwargs "scale"
- fixed internal CI

cc: @haowhsu-quic , @winskuo-quic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: qualcomm Changes to the Qualcomm backend delegate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants