Skip to content

Conversation

mergennachin
Copy link
Contributor

@mergennachin mergennachin commented Aug 1, 2025

Looking into resolving this: pytorch/pytorch#159599

A package in requirements-examples.txt had a dependency on torchvision, and we ended up installing stable release from standard pypi package. And transitively we ended up installing stable torch and uninstalling existing torch nightly.

We just need to swap the installation (first install domain libraries and torch) and then necessary examples packages.

Test Plan:

python ./install_requirements.sh --example

Outputs

(executorch_test_9) mnachin@mnachin-mbp executorch % pip freeze | grep torch
pytorch_tokenizers @ file:///Users/mnachin/executorch/extension/llm/tokenizers
torch==2.9.0.dev20250725
torchao @ file:///Users/mnachin/executorch/third-party/ao
torchaudio==2.8.0.dev20250725
torchdata==0.11.0
torchsr==1.0.4
torchtune==0.6.1
torchvision==0.24.0.dev20250725

Copy link

pytorch-bot bot commented Aug 1, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13074

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 103 Pending

As of commit 0cd1c7d with merge base 48e4822 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 1, 2025
Copy link

github-actions bot commented Aug 1, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@mergennachin mergennachin requested review from cccclai, clee2000, larryliu0820 and mcr229 and removed request for cccclai August 1, 2025 22:19
@mergennachin mergennachin force-pushed the fix_installation_2 branch 2 times, most recently from a26c018 to c643605 Compare August 1, 2025 22:26
A package in requirements-examples.txt had a dependency on torchvision, and we ended up installing stable release from standard pypi package. And transitively we ended up installing stable torch and uninstalling torch library.
@mergennachin mergennachin merged commit 094b3c4 into main Aug 1, 2025
220 of 225 checks passed
@mergennachin mergennachin deleted the fix_installation_2 branch August 1, 2025 22:54
agrima1304 pushed a commit to agrima1304/executorch that referenced this pull request Aug 26, 2025
Looking into resolving this:
pytorch/pytorch#159599

A package in requirements-examples.txt had a dependency on torchvision,
and we ended up installing stable release from standard pypi package.
And transitively we ended up installing stable torch and uninstalling
existing torch nightly.

We just need to swap the installation (first install domain libraries
and torch) and then necessary examples packages.

Test Plan: 

`python ./install_requirements.sh --example`

Outputs

```
(executorch_test_9) mnachin@mnachin-mbp executorch % pip freeze | grep torch
pytorch_tokenizers @ file:///Users/mnachin/executorch/extension/llm/tokenizers
torch==2.9.0.dev20250725
torchao @ file:///Users/mnachin/executorch/third-party/ao
torchaudio==2.8.0.dev20250725
torchdata==0.11.0
torchsr==1.0.4
torchtune==0.6.1
torchvision==0.24.0.dev20250725
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants