Arm backend: Move quant util functions to closer to usage #13094
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following functions are only used in quantization_annotator and can
therefore be moved from arm_quantizer_utils.py to
quantization_annotator.py:
* is_large_scalar
* is_non_float_tensor
* get_node_target
Additionally, is_ok_for_quantization is removed. It combined the
is_large_scalar and is_non_float_tensor checks into one, which is now
done directly where is_ok_for_quantization was used.
Change-Id: I3d8a974bfca0e59c0a22e52be16e36a8039c8029
Signed-off-by: Sebastian Larsson <sebastian.larsson@arm.com>
Sebastian-Larsson
added
the
partner: arm
Sebastian-Larsson
added
ciflow/trunk
release notes: none
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13094
Note: Links to docs will display an error until the docs builds have been completed. ❌ 4 New Failures, 1 Unrelated FailureAs of commit 4a35dd9 with merge base 8d0053c ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
|
CI failures are unrelated |
oscarandersson8218
approved these changes
Aug 5, 2025
agrima1304
pushed a commit
to agrima1304/executorch
that referenced
this pull request
Aug 26, 2025
) The following functions are only used in quantization_annotator and can therefore be moved from arm_quantizer_utils.py to quantization_annotator.py: * is_large_scalar * is_non_float_tensor * get_node_target Additionally, is_ok_for_quantization is removed. It combined the is_large_scalar and is_non_float_tensor checks into one, which is now done directly where is_ok_for_quantization was used. cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 Signed-off-by: Sebastian Larsson <sebastian.larsson@arm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following functions are only used in quantization_annotator and can therefore be moved from arm_quantizer_utils.py to
quantization_annotator.py:
Additionally, is_ok_for_quantization is removed. It combined the is_large_scalar and is_non_float_tensor checks into one, which is now done directly where is_ok_for_quantization was used.
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218