Extract common helper and constants into sepearate files for reusability #13109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larryliu0820
requested review from
jackzhxng,
swolchok,
mergennachin and
lucylq
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13109
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 3 New Failures, 1 Pending, 1 Unrelated FailureAs of commit 16b431c with merge base 964a57a ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D78997240 |
larryliu0820
added
the
release notes: none
jackzhxng
approved these changes
Aug 5, 2025
…ity (#13109) Summary: Extracting out `constants.h` and `llm_runner_helper.h/cpp` to make them reusable by multimodal runner. Reviewed By: jackzhxng Differential Revision: D78997240
facebook-github-bot
force-pushed
the
export-D78997240
branch
from
30e5b1e to
16b431c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D78997240 |
agrima1304
pushed a commit
to agrima1304/executorch
that referenced
this pull request
Aug 26, 2025
Differential Revision: D78997240 Pull Request resolved: pytorch#13109
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Extracting out
constants.handllm_runner_helper.h/cppto make them reusable by multimodal runner.Differential Revision: D78997240