Skip to content

Conversation

rohansjoshi
Copy link
Contributor

Summary: The README should say to set ANDROID_SDK (not ANDROID_HOME, which is set inside the script build_android_library.sh)

Reviewed By: cccclai

Differential Revision: D79387440

Copy link

pytorch-bot bot commented Aug 4, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13112

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 1 Unrelated Failure

As of commit 1850d99 with merge base 3e70463 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 4, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D79387440

Copy link

github-actions bot commented Aug 4, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Summary:

The README should say to set ANDROID_SDK (not ANDROID_HOME, which is set inside the script `build_android_library.sh`)

Reviewed By: cccclai

Differential Revision: D79387440
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D79387440

@facebook-github-bot facebook-github-bot merged commit b92c5b4 into pytorch:main Aug 5, 2025
100 of 105 checks passed
agrima1304 pushed a commit to agrima1304/executorch that referenced this pull request Aug 26, 2025
Differential Revision: D79387440

Pull Request resolved: pytorch#13112
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants