Test xnnpack with pybindings #13133
Merged
Test xnnpack with pybindings #13133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13133
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 2 Unrelated FailuresAs of commit eaf6b5e with merge base 0f22062 ( NEW FAILURE - The following job has failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
larryliu0820
added
the
release notes: none
digantdesai
reviewed
Aug 6, 2025
.ci/scripts/test_model.sh
Outdated
| if [[ ${WITH_QUANTIZATION} == true ]]; then | ||
| SUFFIX="q8" | ||
| "${PYTHON_EXECUTABLE}" -m examples.xnnpack.aot_compiler --model_name="${MODEL_NAME}" --delegate --quantize | ||
| "${PYTHON_EXECUTABLE}" -m examples.xnnpack.aot_compiler --model_name="${MODEL_NAME}" --delegate --quantize --test_with_pybindings |
There was a problem hiding this comment.
so we always want to run first with pybind and then run with the standalone runner below?
There was a problem hiding this comment.
I don't see any reason not to, especially from test_model.sh
jathu
approved these changes
Aug 7, 2025
larryliu0820
force-pushed
the
test_xnnpack_with_pybindings
branch
from
48b63a6 to
b3fe1fe
Compare
StrycekSimon
pushed a commit
to nxp-upstream/executorch
that referenced
this pull request
Sep 23, 2025
Make sure we run xnnpack delegated model using pybindings, in `test_models.sh`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure we run xnnpack delegated model using pybindings, in
test_models.sh.