raise error when trying to save an etrecord missing essential info #13143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as title Differential Revision: [D79687142](https://our.internmc.facebook.com/intern/diff/D79687142/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13143
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 1 Unrelated FailureAs of commit 2d44628 with merge base a8fe653 ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Gasoonjia
added a commit
that referenced
this pull request
Aug 5, 2025
as title Differential Revision: [D79687142](https://our.internmc.facebook.com/intern/diff/D79687142/) ghstack-source-id: 300974056 Pull Request resolved: #13143
meta-cla
bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D79687142 |
…ial info" as title Differential Revision: [D79687142](https://our.internmc.facebook.com/intern/diff/D79687142/) [ghstack-poisoned]
Gasoonjia
added a commit
that referenced
this pull request
Aug 6, 2025
Pull Request resolved: #13143 as title ghstack-source-id: 301049322 @exported-using-ghexport Differential Revision: [D79687142](https://our.internmc.facebook.com/intern/diff/D79687142/)
|
This pull request was exported from Phabricator. Differential Revision: D79687142 |
…ial info" as title Differential Revision: [D79687142](https://our.internmc.facebook.com/intern/diff/D79687142/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D79687142 |
…ial info" as title Differential Revision: [D79687142](https://our.internmc.facebook.com/intern/diff/D79687142/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D79687142 |
…ial info" as title Differential Revision: [D79687142](https://our.internmc.facebook.com/intern/diff/D79687142/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D79687142 |
…ial info" as title Differential Revision: [D79687142](https://our.internmc.facebook.com/intern/diff/D79687142/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D79687142 |
…ial info" as title Differential Revision: [D79687142](https://our.internmc.facebook.com/intern/diff/D79687142/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D79687142 |
JacobSzwejbka
approved these changes
Aug 8, 2025
facebook-github-bot
merged commit 1b3c2bf
into
gh/gasoonjia/35/base
100 of 104 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
Gasoonjia
added a commit
that referenced
this pull request
Aug 8, 2025
…13231) This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: #13143 by @Gasoonjia ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/gasoonjia/35/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/gasoonjia/35/head Merge bot PR base: https://github.com/pytorch/executorch/tree/main Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/gasoonjia/35/orig @diff-train-skip-merge Co-authored-by: gasoonjia <gasoonjia@icloud.com> Co-authored-by: Gasoonjia <gasoonjia@meta.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
as title
Differential Revision: D79687142