Non-fatal error when ET_SWITCH encounters unsupported dtype #13359

manuelcandales · 2025-08-13T02:33:15Z

Summary: Modify ET_INTERNAL_SWITCH macro, so that we fail non-fatally in the default clause when we encounter an unsupported dtype.

Differential Revision: D80141272

pytorch-bot · 2025-08-13T02:33:18Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13359

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 16 New Failures, 2 Unrelated Failures

As of commit 362cd53 with merge base 9359481 ():

NEW FAILURES - The following jobs have failed:

Apple / build-frameworks-ios / macos-job (gh)
Failed to CreateArtifact: Unable to make request: ENOTFOUND
Build documentation / build (buck2) / Build doc (gh)
At least one of the pre-conditions you specified did not hold
pull / unittest-arm-backend-with-no-fvp (test_pytest_models) / linux-job (gh)
RuntimeError: Command docker exec -t c50e2199098e88b27f0329acbbb6e47951446dca7a24a18ca2e7b1cf2bf36d05 /exec failed with exit code 1
pull / unittest-arm-backend-with-no-fvp (test_pytest_ops) / linux-job (gh)
RuntimeError: Command docker exec -t c1fc0d30416128c673c4f282be9c37d36aded2bd261e46518a9457eadf1d8f12 /exec failed with exit code 1
pull / unittest-editable / linux / linux-job (gh)
exir/tests/test_remove_unused_parameters_pass.py::TestRemoveUnusedParametersPass::test_remove_unused_parameters_nested_e2e_to_edge
trunk / test-arm-backend (test_models_ethos-u55) / linux-job (gh)
RuntimeError: Command docker exec -t b157130baa24f377b52052c6d102d4340d6a56d49b9c15ab71ffb47cd1e3876e /exec failed with exit code 1
trunk / test-arm-backend (test_models_ethos-u85) / linux-job (gh)
RuntimeError: Command docker exec -t 202e8f82a69a30edb97f942f33deac81184213ff37f380d0cde0d348ddafe4c4 /exec failed with exit code 1
trunk / test-arm-backend (test_models_tosa) / linux-job (gh)
RuntimeError: Command docker exec -t f63532e2c723bd187408923b201ff2d76734a62bdaf07bf18d890169838fe42f /exec failed with exit code 1
trunk / test-arm-backend (test_pytest_models_ethosu_fvp) / linux-job (gh)
RuntimeError: Command docker exec -t 7956a6560d5457ac417f4aee8f5d02bf6255cde8fe6ccb84b04515a7bfa4ed22 /exec failed with exit code 1
trunk / test-arm-backend (test_pytest_ops_ethosu_fvp) / linux-job (gh)
RuntimeError: Command docker exec -t eed592e21e6625ff809a5febb389a6a7a3904346f03e69a24511ea36f2dfd63a /exec failed with exit code 1
trunk / test-arm-backend (test_run_ethosu_fvp) / linux-job (gh)
RuntimeError: Command docker exec -t fe2857cdeb5b717014ae509a717017b229c1a5c1ee37e0b06af0a962f95b5d1c /exec failed with exit code 1
trunk / test-arm-backend (test_smaller_stories_llama) / linux-job (gh)
RuntimeError: Command docker exec -t 61f8de1b735d884e5994acfec8078721856c70c272b694e3a6b2ac9518008983 /exec failed with exit code 1
trunk / test-arm-cortex-m-size-test (bare_metal) / linux-job (gh)
RuntimeError: Command docker exec -t d1a54a4e895a992eba4066305715436e9d8bc14e3dc5424ba23b80407180683e /exec failed with exit code 1
trunk / test-arm-cortex-m-size-test (zephyr-preset) / linux-job (gh)
RuntimeError: Command docker exec -t 17177abeda83810b35cad9beb6703a7454609853767dd6d9fe5ae8aecddd8ec4 /exec failed with exit code 1
trunk / test-arm-ootb-linux / linux-job (gh)
RuntimeError: Command docker exec -t 45ea8c509ffe2151fc6fb22cc6c5882789f376e0fbac7391f4f9d14602f1cad3 /exec failed with exit code 1
trunk / test-huggingface-transformers-coreml (qwen3-1.7b|xnnpack|--quantize) / macos-job (gh)
RuntimeError: Command bash /Users/runner/work/_temp/exec_script failed with exit code 139

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

Apple / build-benchmark-app / macos-job (gh) (trunk failure)
RuntimeError: Command bash /Users/runner/work/_temp/exec_script failed with exit code 65
trunk / test-llama-torchao-lowbit / macos-job (gh) (trunk failure)
RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 1

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot · 2025-08-13T02:33:26Z

This pull request was exported from Phabricator. Differential Revision: D80141272

…13359) Summary: Modify `ET_INTERNAL_SWITCH` macro, so that we fail non-fatally in the default clause when we encounter an unsupported dtype. Differential Revision: D80141272

facebook-github-bot · 2025-08-17T16:19:28Z

This pull request was exported from Phabricator. Differential Revision: D80141272

…13359) Summary: Modify `ET_INTERNAL_SWITCH` macro, so that we fail non-fatally in the default clause when we encounter an unsupported dtype. Differential Revision: D80141272

facebook-github-bot · 2025-08-17T17:27:38Z

This pull request was exported from Phabricator. Differential Revision: D80141272

…13359) Summary: Modify `ET_INTERNAL_SWITCH` macro, so that we fail non-fatally in the default clause when we encounter an unsupported dtype. Differential Revision: D80141272

facebook-github-bot · 2025-08-17T19:40:13Z

This pull request was exported from Phabricator. Differential Revision: D80141272

…13359) Summary: Modify `ET_INTERNAL_SWITCH` macro, so that we fail non-fatally in the default clause when we encounter an unsupported dtype. Differential Revision: D80141272

facebook-github-bot · 2025-08-17T20:17:40Z

This pull request was exported from Phabricator. Differential Revision: D80141272

…13359) Summary: Modify `ET_INTERNAL_SWITCH` macro, so that we fail non-fatally in the default clause when we encounter an unsupported dtype. Differential Revision: D80141272

facebook-github-bot · 2025-08-17T20:35:48Z

This pull request was exported from Phabricator. Differential Revision: D80141272

…13359) Summary: Modify `ET_INTERNAL_SWITCH` macro, so that we fail non-fatally in the default clause when we encounter an unsupported dtype. Differential Revision: D80141272

facebook-github-bot · 2025-08-18T18:36:52Z

This pull request was exported from Phabricator. Differential Revision: D80141272

…13359) Summary: Modify `ET_INTERNAL_SWITCH` macro, so that we fail non-fatally in the default clause when we encounter an unsupported dtype. Differential Revision: D80141272

facebook-github-bot · 2025-08-18T22:22:34Z

This pull request was exported from Phabricator. Differential Revision: D80141272

digantdesai · 2025-08-19T10:53:20Z

runtime/core/exec_aten/util/scalar_type_util.h

+    switch (_st) {                                             \
+      __VA_ARGS__                                              \
+      default:                                                 \
+        CONTEXT.fail(torch::executor::Error::InvalidArgument); \


Nit: Leave a comment along the lines "this sets the return code which should be checked by the caller"

swolchok · 2025-08-19T15:27:51Z

kernels/portable/cpu/op_fill.cpp


  ET_SWITCH_REALHBBF16_TYPES(a_type, ctx, op_name, CTYPE_A, [&] {
-    CTYPE_A b_casted;
+    CTYPE_A b_casted{};


this took me a minute -- we now return all-zeros output and signal a failure when there's an unsupported dtype instead of terminating the process. this seems fine.

swolchok · 2025-08-19T15:29:49Z

kernels/portable/cpu/util/dtype_util.h

+        "Unhandled dtype %s for %s",
+        ::executorch::runtime::toString(t.scalar_type()),
+        op_name);
+  }


Sadly, load_and_convert has undefined behavior in this case. We should probably return CTYPE_COMPUTE(); to be safe.

swolchok · 2025-08-19T15:31:13Z

kernels/portable/cpu/util/dtype_util.h

+        "Unhandled dtype %s for %s",
+        ::executorch::runtime::toString(t.scalar_type()),
+        op_name);
+  }


ditto undefined behavior

swolchok · 2025-08-19T15:32:13Z

kernels/portable/cpu/util/dtype_util.h

+        "Unhandled dtype %s for %s",
+        ::executorch::runtime::toString(t.scalar_type()),
+        op_name);
+  }


ditto undefined behavior; for the convert_and_store case it seems easiest to just skip the write to be safe.

swolchok · 2025-08-19T15:33:04Z

kernels/portable/cpu/util/dtype_util.h

+        "Unhandled dtype %s for %s",
+        ::executorch::runtime::toString(t.scalar_type()),
+        op_name);
+  }


ditto undefined behavior

swolchok · 2025-08-19T15:34:22Z

kernels/quantized/cpu/embeddingxb.cpp

-  (void)context;
-  resize_out_tensor(weight, indices, out, weight_nbit);
-  return quantized_embedding_xbit_out(
+  auto context = KernelRuntimeContext();


nit: KernelRuntimeContext context;

Summary: Modify `ET_INTERNAL_SWITCH` macro, so that we fail non-fatally in the default clause when we encounter an unsupported dtype. Reviewed By: digantdesai Differential Revision: D80141272

…13359) Summary: Modify `ET_INTERNAL_SWITCH` macro, so that we fail non-fatally in the default clause when we encounter an unsupported dtype. Reviewed By: digantdesai Differential Revision: D80141272

facebook-github-bot · 2025-08-20T22:02:39Z

This pull request was exported from Phabricator. Differential Revision: D80141272

facebook-github-bot · 2025-08-20T22:05:55Z

This pull request was exported from Phabricator. Differential Revision: D80141272

…13359) Summary: Pull Request resolved: pytorch#13359 Modify `ET_INTERNAL_SWITCH` macro, so that we fail non-fatally in the default clause when we encounter an unsupported dtype. Reviewed By: digantdesai Differential Revision: D80141272

…13359) Summary: Modify `ET_INTERNAL_SWITCH` macro, so that we fail non-fatally in the default clause when we encounter an unsupported dtype. Reviewed By: digantdesai Differential Revision: D80141272

facebook-github-bot · 2025-08-21T01:45:19Z

This pull request was exported from Phabricator. Differential Revision: D80141272

Differential Revision: D80141272 Pull Request resolved: pytorch#13359

manuelcandales requested review from JacobSzwejbka, lucylq and swolchok as code owners August 13, 2025 02:33

meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 13, 2025

facebook-github-bot added the fb-exported label Aug 13, 2025

manuelcandales force-pushed the export-D80141272 branch from ca35dd9 to c66f982 Compare August 17, 2025 16:19

manuelcandales requested review from jackzhxng, larryliu0820, mergennachin and shoumikhin as code owners August 17, 2025 16:19

manuelcandales force-pushed the export-D80141272 branch from c66f982 to d710186 Compare August 17, 2025 17:27

manuelcandales force-pushed the export-D80141272 branch from d710186 to e0b2494 Compare August 17, 2025 19:40

manuelcandales force-pushed the export-D80141272 branch from e0b2494 to dfce728 Compare August 17, 2025 20:17

manuelcandales force-pushed the export-D80141272 branch from dfce728 to 1292927 Compare August 17, 2025 20:35

manuelcandales requested a review from digantdesai August 18, 2025 15:33

digantdesai added the ciflow/trunk label Aug 18, 2025

manuelcandales force-pushed the export-D80141272 branch from 0831ea6 to 62618fc Compare August 18, 2025 18:36

manuelcandales force-pushed the export-D80141272 branch from 62618fc to 855fecb Compare August 18, 2025 22:22

digantdesai reviewed Aug 19, 2025

View reviewed changes

digantdesai approved these changes Aug 19, 2025

View reviewed changes

swolchok reviewed Aug 19, 2025

View reviewed changes

manuelcandales force-pushed the export-D80141272 branch from 855fecb to b511926 Compare August 20, 2025 21:59

manuelcandales force-pushed the export-D80141272 branch from b511926 to cc91a52 Compare August 20, 2025 22:02

manuelcandales force-pushed the export-D80141272 branch from cc91a52 to ff75457 Compare August 20, 2025 22:05

Non-fatal error when ET_SWITCH encounters unsupported dtype (pytorch#…

362cd53

…13359) Summary: Modify `ET_INTERNAL_SWITCH` macro, so that we fail non-fatally in the default clause when we encounter an unsupported dtype. Reviewed By: digantdesai Differential Revision: D80141272

manuelcandales force-pushed the export-D80141272 branch from ff75457 to 362cd53 Compare August 21, 2025 01:45

facebook-github-bot merged commit 3dac421 into pytorch:main Aug 21, 2025
225 of 245 checks passed

agrima1304 pushed a commit to agrima1304/executorch that referenced this pull request Aug 26, 2025

Non-fatal error when ET_SWITCH encounters unsupported dtype

454b8a1

Differential Revision: D80141272 Pull Request resolved: pytorch#13359

Non-fatal error when ET_SWITCH encounters unsupported dtype #13359

Non-fatal error when ET_SWITCH encounters unsupported dtype #13359

Uh oh!

Conversation

manuelcandales commented Aug 13, 2025

Uh oh!

pytorch-bot bot commented Aug 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13359

❌ 16 New Failures, 2 Unrelated Failures

Uh oh!

facebook-github-bot commented Aug 13, 2025

Uh oh!

facebook-github-bot commented Aug 17, 2025

Uh oh!

facebook-github-bot commented Aug 17, 2025

Uh oh!

facebook-github-bot commented Aug 17, 2025

Uh oh!

facebook-github-bot commented Aug 17, 2025

Uh oh!

facebook-github-bot commented Aug 17, 2025

Uh oh!

facebook-github-bot commented Aug 18, 2025

Uh oh!

facebook-github-bot commented Aug 18, 2025

Uh oh!

digantdesai Aug 19, 2025

Choose a reason for hiding this comment

Uh oh!

swolchok Aug 19, 2025

Choose a reason for hiding this comment

Uh oh!

swolchok Aug 19, 2025

Choose a reason for hiding this comment

Uh oh!

swolchok Aug 19, 2025

Choose a reason for hiding this comment

Uh oh!

swolchok Aug 19, 2025

Choose a reason for hiding this comment

Uh oh!

swolchok Aug 19, 2025

Choose a reason for hiding this comment

Uh oh!

swolchok Aug 19, 2025

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot commented Aug 20, 2025

Uh oh!

facebook-github-bot commented Aug 20, 2025

Uh oh!

facebook-github-bot commented Aug 21, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

pytorch-bot bot commented Aug 13, 2025 •

edited

Loading