-
Notifications
You must be signed in to change notification settings - Fork 683
Arm backend: Introduce documentation for VGF #13369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13369
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 49 Unrelated FailuresAs of commit bd066a4 with merge base 9cfb684 ( NEW FAILURES - The following jobs have failed:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
lint-check urls is expected until the new urls are made live in upstream documentation. |
Thanks Mergen, comments addressed. I don't beleive we need to merge as there are no conflicts. |
Most tests fails are unrelated but I see this stopping the merged https://github.com/pytorch/executorch/actions/runs/16943915693/job/48019945078?pr=13369 ---- log snippet ----
|
Hi Zingo - if there's a better way to handle URLs introduced by the commit, or use abstracted links between the readme's and rendered docs, let me know, but I expect those to be populated on main once this review is comitted. For example, tutorial-arm exists in the rendered docs for this PR: https://docs-preview.pytorch.org/pytorch/executorch/13369/tutorial-arm.html |
I have no idea maybe @digantdesai or someone can override to merge. |
Ok, i've gone with removing them for now. The other problem with those links is they're to a specific branch (in this case main) whereas they'd ideally link to the relevant release/main/stable, which again doesn't seem technically possible. |
Test fails are unrelated |
Signed-off-by: Rob Elliott <Robert.Elliott@arm.com> Change-Id: I303bd9d91c80edd5176f242efecfd616b987860e
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
Signed-off-by: Rob Elliott <robert.elliott@arm.com> Change-Id: I24b31ec7e31c2230cf7d48bbf03cd5f81dd064ba
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
and, another go - i've removed the skip-url-lint because it stops that job reporting (as suggested in the error output) but that also means a required job doesn't report, blocking merge. |
Revising documentation for a number of historical changes, and to add the recently introduced VGF backend. Signed-off-by: Rob Elliott <Robert.Elliott@arm.com>
Revising documentation for a number of historical changes, and to add the recently introduced VGF backend.
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218