Skip to content

Conversation

robell
Copy link
Collaborator

@robell robell commented Aug 13, 2025

Revising documentation for a number of historical changes, and to add the recently introduced VGF backend.

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

Copy link

pytorch-bot bot commented Aug 13, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13369

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 49 Unrelated Failures

As of commit bd066a4 with merge base 9cfb684 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 13, 2025
@robell robell added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes labels Aug 13, 2025
@robell
Copy link
Collaborator Author

robell commented Aug 13, 2025

lint-check urls is expected until the new urls are made live in upstream documentation.
the failure is unrelated - this change does not modify code.

@robell robell requested review from zingo and tom-arm August 13, 2025 11:13
@robell
Copy link
Collaborator Author

robell commented Aug 13, 2025

Thanks Mergen, comments addressed.
Thanks for the update/merge commit Zingo - for some reason it's saying out of date, but i'd rebased to executorch/main a couple hours ago and force pushed but it doesn't seem to resolve the message.

I don't beleive we need to merge as there are no conflicts.

@zingo
Copy link
Collaborator

zingo commented Aug 14, 2025

Most tests fails are unrelated but I see this stopping the merged

https://github.com/pytorch/executorch/actions/runs/16943915693/job/48019945078?pr=13369

---- log snippet ----

FAIL 000 https://github.com/pytorch/executorch/blob/main/examples/arm/vgf_minimal_example.ipynb docs/source/tutorial-arm.md
FAIL 404 https://docs.pytorch.org/executorch/main/tutorial-arm.html backends/arm/README.md
FAIL 404 https://docs.pytorch.org/executorch/main/tutorial-arm.html examples/arm/ethos_u_minimal_example.ipynb

@robell
Copy link
Collaborator Author

robell commented Aug 14, 2025

Hi Zingo - if there's a better way to handle URLs introduced by the commit, or use abstracted links between the readme's and rendered docs, let me know, but I expect those to be populated on main once this review is comitted.

For example, tutorial-arm exists in the rendered docs for this PR: https://docs-preview.pytorch.org/pytorch/executorch/13369/tutorial-arm.html

@zingo
Copy link
Collaborator

zingo commented Aug 14, 2025

Hi Zingo - if there's a better way to handle URLs introduced by the commit, or use abstracted links between the readme's and rendered docs, let me know, but I expect those to be populated on main once this review is comitted.

For example, tutorial-arm exists in the rendered docs for this PR: https://docs-preview.pytorch.org/pytorch/executorch/13369/tutorial-arm.html

I have no idea maybe @digantdesai or someone can override to merge.
Maybe some sort of relative links can be used, or we have to do it in 2 PRs.

@robell
Copy link
Collaborator Author

robell commented Aug 14, 2025

Ok, i've gone with removing them for now. The other problem with those links is they're to a specific branch (in this case main) whereas they'd ideally link to the relevant release/main/stable, which again doesn't seem technically possible.

@zingo
Copy link
Collaborator

zingo commented Aug 14, 2025

Test fails are unrelated

robell added 6 commits August 14, 2025 16:07
Signed-off-by: Rob Elliott <Robert.Elliott@arm.com>
Change-Id: I303bd9d91c80edd5176f242efecfd616b987860e
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
Change-Id: I24b31ec7e31c2230cf7d48bbf03cd5f81dd064ba
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
Signed-off-by: Rob Elliott <robert.elliott@arm.com>
@robell
Copy link
Collaborator Author

robell commented Aug 14, 2025

and, another go - i've removed the skip-url-lint because it stops that job reporting (as suggested in the error output) but that also means a required job doesn't report, blocking merge.
Hopefully this time the job runs and the spurious errors have cleared, and we can get this in.

@zingo zingo merged commit b1d09fd into pytorch:main Aug 14, 2025
186 of 237 checks passed
agrima1304 pushed a commit to agrima1304/executorch that referenced this pull request Aug 26, 2025
Revising documentation for a number of historical changes, and to add
the recently introduced VGF backend.

Signed-off-by: Rob Elliott <Robert.Elliott@arm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants