Add 1MB temp allocator for executor #13533
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13533
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 11 Pending, 2 Unrelated FailuresAs of commit ef81355 with merge base aefdc8d ( NEW FAILURE - The following job has failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D80578578 |
This PR needs a
|
zonglinpeng
force-pushed
the
export-D80578578
branch
from
56ac74d to
371472d
Compare
zonglinpeng
added a commit
to zonglinpeng/executorch
that referenced
this pull request
Aug 20, 2025
Summary: Method::load creates a PlatformMemoryAllocator as fallback when no temp allocator is provided. So our KernelRuntimeContext will always be PlatformMemoryAllocator since no temp mem is allocated. Overrides et_pal_allocate to allocate code pointer: https://fburl.com/code/216qnnvt Differential Revision: D80578578
|
This pull request was exported from Phabricator. Differential Revision: D80578578 |
Summary: **Have to ship this as an intermediate step to unblock 3 workstreams on the stack** Modify aten tests to ingress FACTO generated testcases. - Each test gets 30~50 cases with good coverage on - Optimized VS unoptimized flows - dtype switch cases Known issues: - FACTO test class is too big to run on default "heavyweight" CI - current skipping the whole target on CI. Will add back once skycastle flow is ready - some FACTO is creating inputs that kernels does not handle, mainly dtypes - will create exception handling for that. - TODO marks the 2 FACTO doesnt work well on the 2 ops. Reviewed By: manuelcandales, hsharma35 Differential Revision: D79121474
Summary: solve ``` *Error* Unhandled user exception: LoadProhibitedCause (0x00000000) ``` Differential Revision: D80487955
Summary: Method::load creates a PlatformMemoryAllocator as fallback when no temp allocator is provided. So our KernelRuntimeContext will always be PlatformMemoryAllocator since no temp mem is allocated. Overrides et_pal_allocate to allocate code pointer: https://fburl.com/code/216qnnvt Differential Revision: D80578578
zonglinpeng
force-pushed
the
export-D80578578
branch
from
371472d to
3d6b898
Compare
|
This pull request was exported from Phabricator. Differential Revision: D80578578 |
eigen-k
approved these changes
Aug 21, 2025
jackzhxng
reviewed
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Method::load creates a PlatformMemoryAllocator as fallback when no temp allocator is provided. So our KernelRuntimeContext will always be PlatformMemoryAllocator since no temp mem is allocated. Overrides et_pal_allocate to allocate
code pointer: https://fburl.com/code/216qnnvt
Differential Revision: D80578578