Arm backend: Use cmake for building in Ethos-U jupyter example #13630
Conversation
Building the example application using cmake is now straight forward enough to not need any helper scripts. Additionally simplify the the example + path setup in the executor runner cmake script and make the default path match the example. Signed-off-by: Adrian Lundell <adrian.lundell@arm.com> Change-Id: I3d650e9db0519f40a441c154aa7f64cc39a9e72c
AdrianLundell
requested review from
larryliu0820,
kirklandsign and
digantdesai
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13630
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Cancelled JobAs of commit 53f21c9 with merge base c70aeda ( NEW FAILURE - The following job has failed:
CANCELLED JOB - The following job was cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
AdrianLundell
added
module: arm
meta-cla
bot
added
the
CLA Signed
|
Unrelated CI failures |
…ch#13630) Building the example application using cmake is now straight forward enough to not need any helper scripts. Additionally simplify the the example + path setup in the executor runner cmake script and make the default path match the example. cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 Signed-off-by: Adrian Lundell <adrian.lundell@arm.com>
| "%%bash \n", | ||
| "source ethos-u-scratch/setup_path.sh\n", | ||
| "\n", | ||
| "# Build example executor runner application to examples/arm/ethos_u_minimal_example\n", |
There was a problem hiding this comment.
I think we run this notebook in CI but just to avoid code here, can we use some script like build_executor.sh which is covered by CI?
There was a problem hiding this comment.
We wanted to avoid the "bespoke inconsistent scripts" mentioned in #10661 and show the build process as true to reality as possible here. We want the cmake to be documented somewhere imo, so adding an additional script only forces us to document and maintain both that script and the real flow. Why do you want to avoid the code here?
The notebook should be tested here:
executorch/.github/workflows/trunk.yml
Line 432 in deaf37f
There was a problem hiding this comment.
I think I remember the test_arm_ootb.sh script. I was highlight to just call existing build scripts instead of spelling out the cmake command here.
Building the example application using cmake is now straight forward enough to not need any helper scripts.
Additionally simplify the the example + path setup in the executor runner cmake script and make the default path match the example.
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218