Disable mm + add -> addmm fusion if added tensor rank >2 #13632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

facebook-github-bot merged 1 commit into pytorch:main from hsharma35:export-D80906791

Aug 26, 2025

Contributor

hsharma35 commented Aug 25, 2025

Summary: Addmm meta kernel allows the added tensor rank to be >2 but the implementation does not. This diff disables fusion of mm + add in such cases.

Differential Revision: D80906791

pytorch-bot bot commented Aug 25, 2025 •

edited

Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13632

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 2 Unrelated Failures

As of commit 175c8e6 with merge base d5fb6aa ():

NEW FAILURES - The following jobs have failed:

Build documentation / build (buck2) / Build doc (gh)
At least one of the pre-conditions you specified did not hold
pull / unittest-arm-backend-with-no-fvp (test_pytest_ops) / linux-job (gh)
RuntimeError: Command docker exec -t 97ef2a18dcb157c64303f6a15a003ffd4796c0825f797a362da75382769f04ff /exec failed with exit code 1

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

pull / unittest / macos / macos-job (gh) (trunk failure)
RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 1
pull / unittest-editable / macos / macos-job (gh) (trunk failure)
RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 1

This comment was automatically generated by Dr. CI and updates every 15 minutes.

meta-cla bot added the CLA Signed label

Contributor

facebook-github-bot commented Aug 25, 2025

This pull request was exported from Phabricator. Differential Revision: D80906791

facebook-github-bot added the fb-exported label

github-actions bot commented Aug 25, 2025

This PR needs a `release notes:` label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

hsharma35 added a commit to hsharma35/executorch that referenced this pull request


          Disable mm + add -> addmm fusion if added tensor rank >2 (pytorch#13632)

9beaf31

Summary:

Addmm meta kernel allows the added tensor rank to be >2 but the implementation does not. This diff disables fusion of mm + add in such cases.

Differential Revision: D80906791

zonglinpeng approved these changes

View reviewed changes

hsharma35 force-pushed the export-D80906791 branch from 2c314b5 to 7fa2bbd Compare

August 25, 2025 20:21

hsharma35 added a commit to hsharma35/executorch that referenced this pull request


          Disable mm + add -> addmm fusion if added tensor rank >2 (pytorch#13632)

7fa2bbd

Summary:

Addmm meta kernel allows the added tensor rank to be >2 but the implementation does not. This diff disables fusion of mm + add in such cases.

Reviewed By: zonglinpeng

Differential Revision: D80906791

hsharma35 added a commit to hsharma35/executorch that referenced this pull request


          Disable mm + add -> addmm fusion if added tensor rank >2 (pytorch#13632)

56029a1

Summary:

Addmm meta kernel allows the added tensor rank to be >2 but the implementation does not. This diff disables fusion of mm + add in such cases.

Reviewed By: zonglinpeng

Differential Revision: D80906791

hsharma35 force-pushed the export-D80906791 branch from 7fa2bbd to 56029a1 Compare

August 25, 2025 20:22

Contributor

facebook-github-bot commented Aug 25, 2025

This pull request was exported from Phabricator. Differential Revision: D80906791

hsharma35 added a commit to hsharma35/executorch that referenced this pull request


          Disable mm + add -> addmm fusion if added tensor rank >2 (pytorch#13632)

d780344

Summary:

Addmm meta kernel allows the added tensor rank to be >2 but the implementation does not. This diff disables fusion of mm + add in such cases.

Reviewed By: zonglinpeng

Differential Revision: D80906791

hsharma35 added a commit to hsharma35/executorch that referenced this pull request


          Disable mm + add -> addmm fusion if added tensor rank >2 (pytorch#13632)

c331cfd

Summary:

Addmm meta kernel allows the added tensor rank to be >2 but the implementation does not. This diff disables fusion of mm + add in such cases.

Reviewed By: zonglinpeng

Differential Revision: D80906791

hsharma35 added a commit to hsharma35/executorch that referenced this pull request


          Disable mm + add -> addmm fusion if added tensor rank >2 (pytorch#13632)

3adaaa9

Summary:

Addmm meta kernel allows the added tensor rank to be >2 but the implementation does not. This diff disables fusion of mm + add in such cases.

Reviewed By: zonglinpeng

Differential Revision: D80906791

Contributor

facebook-github-bot commented Aug 25, 2025

This pull request was exported from Phabricator. Differential Revision: D80906791

hsharma35 added a commit to hsharma35/executorch that referenced this pull request


          Disable mm + add -> addmm fusion if added tensor rank >2 (pytorch#13632)

8c52104

Summary:
Pull Request resolved: pytorch#13632

Addmm meta kernel allows the added tensor rank to be >2 but the implementation does not. This diff disables fusion of mm + add in such cases.

Reviewed By: zonglinpeng

Differential Revision: D80906791

hsharma35 force-pushed the export-D80906791 branch 2 times, most recently from 8c52104 to 5741526 Compare

August 26, 2025 01:55

hsharma35 added a commit to hsharma35/executorch that referenced this pull request


          Disable mm + add -> addmm fusion if added tensor rank >2 (pytorch#13632)

Summary:

Addmm meta kernel allows the added tensor rank to be >2 but the implementation does not. This diff disables fusion of mm + add in such cases.

Reviewed By: zonglinpeng

Differential Revision: D80906791

hsharma35 added a commit to hsharma35/executorch that referenced this pull request


          Disable mm + add -> addmm fusion if added tensor rank >2 (pytorch#13632)

f4cc345

Summary:

Addmm meta kernel allows the added tensor rank to be >2 but the implementation does not. This diff disables fusion of mm + add in such cases.

Reviewed By: zonglinpeng

Differential Revision: D80906791

hsharma35 added a commit to hsharma35/executorch that referenced this pull request


          Disable mm + add -> addmm fusion if added tensor rank >2 (pytorch#13632)

6d2cd88

Summary:

Addmm meta kernel allows the added tensor rank to be >2 but the implementation does not. This diff disables fusion of mm + add in such cases.

Reviewed By: zonglinpeng

Differential Revision: D80906791

Contributor

facebook-github-bot commented Aug 26, 2025

This pull request was exported from Phabricator. Differential Revision: D80906791

hsharma35 added a commit to hsharma35/executorch that referenced this pull request


          Disable mm + add -> addmm fusion if added tensor rank >2 (pytorch#13632)

93f64fc

Summary:
Pull Request resolved: pytorch#13632

Addmm meta kernel allows the added tensor rank to be >2 but the implementation does not. This diff disables fusion of mm + add in such cases.

Reviewed By: zonglinpeng

Differential Revision: D80906791

hsharma35 force-pushed the export-D80906791 branch from 5741526 to 93f64fc Compare

August 26, 2025 02:00


          Disable mm + add -> addmm fusion if added tensor rank >2 (pytorch#13632)

175c8e6

Summary:

Addmm meta kernel allows the added tensor rank to be >2 but the implementation does not. This diff disables fusion of mm + add in such cases.

Reviewed By: zonglinpeng

Differential Revision: D80906791

hsharma35 force-pushed the export-D80906791 branch from 93f64fc to 175c8e6 Compare

August 26, 2025 04:19

Contributor

facebook-github-bot commented Aug 26, 2025

This pull request was exported from Phabricator. Differential Revision: D80906791

hsharma35 added a commit to hsharma35/executorch that referenced this pull request


          Disable mm + add -> addmm fusion if added tensor rank >2 (pytorch#13632)

ff04c5a

Summary:

Addmm meta kernel allows the added tensor rank to be >2 but the implementation does not. This diff disables fusion of mm + add in such cases.

Reviewed By: zonglinpeng

Differential Revision: D80906791

hsharma35 added a commit to hsharma35/executorch that referenced this pull request


          Disable mm + add -> addmm fusion if added tensor rank >2 (pytorch#13632)

3ea9de6

Summary:

Addmm meta kernel allows the added tensor rank to be >2 but the implementation does not. This diff disables fusion of mm + add in such cases.

Reviewed By: zonglinpeng

Differential Revision: D80906791

facebook-github-bot merged commit 732aff9 into pytorch:main

106 of 112 checks passed

agrima1304 pushed a commit to agrima1304/executorch that referenced this pull request


          Disable mm + add -> addmm fusion if added tensor rank >2

4df836d

Differential Revision: D80906791

Pull Request resolved: pytorch#13632

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed fb-exported