Skip to content

Allow none and string input types for Method #13645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 25, 2025
Merged

Allow none and string input types for Method #13645

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1ce9d34
Allow none and string input types for Method
shoumikhin Aug 25, 2025
fac71cc
Merge branch 'main' into shoumikhin-patch-5-1
shoumikhin Aug 25, 2025
a2730db
Update method.cpp
shoumikhin Aug 25, 2025
aff6511
Update method.cpp
shoumikhin Aug 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions runtime/executor/method.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1055,7 +1055,7 @@ Method::set_input(const EValue& input_evalue, size_t input_idx) {

const auto& e = get_value(get_input_index(input_idx));

if (!e.isTensor() && !e.isScalar()) {
if (!(e.isNone() || e.isTensor() || e.isScalar() || e.isString())) {
#if ET_LOG_ENABLED
std::array<char, kTagNameBufferSize> tag_name;
tag_to_string(e.tag, tag_name.data(), tag_name.size());
Expand Down Expand Up @@ -1088,7 +1088,9 @@ Method::set_input(const EValue& input_evalue, size_t input_idx) {
return Error::InvalidArgument;
}

if (e.isTensor()) {
if (e.isNone()) {
// no-op
} else if (e.isTensor()) {
const auto& t_dst = e.toTensor();
const auto& t_src = input_evalue.toTensor();

Expand Down
Loading