Skip to content

Conversation

mergennachin
Copy link
Contributor

See #13631

Copy link

pytorch-bot bot commented Aug 25, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13651

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 14 Pending

As of commit 14a617a with merge base 2100527 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 25, 2025
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@JacobSzwejbka
Copy link
Contributor

It was hidden because its stale I believe. I was going to clean it up after branch cut

Copy link
Member

@GregoryComer GregoryComer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I probably haven't covered this in enough detail in the new docs flow. I'd like to do a pass on these docs before 1.0 to clean up and homogenize a bit - I'll create a task to track it.

@mergennachin mergennachin merged commit f02fab4 into main Aug 25, 2025
108 of 111 checks passed
@mergennachin mergennachin deleted the fix_cpp_runtime branch August 25, 2025 21:25
agrima1304 pushed a commit to agrima1304/executorch that referenced this pull request Aug 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants