Skip to content

Clean up ET_Check in depthwise conv, replace with assert #13655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 26, 2025
Merged

Clean up ET_Check in depthwise conv, replace with assert #13655

merged 1 commit into from
Aug 26, 2025

Conversation

ethansfng
Copy link
Contributor

Differential Revision: D80952627

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Aug 25, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13655

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 22 Pending, 2 Unrelated Failures

As of commit 0dae951 with merge base dd16790 (image):

NEW FAILURE - The following job has failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 25, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D80952627

@github-actions GitHub Actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@ethansfng @facebook-github-bot
Clean up ET_Check in depthwise conv, replace with assert
0dae951 
Summary: Replace if check with ET_Check assert

Reviewed By: zonglinpeng

Differential Revision: D80952627
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D80952627

@facebook-github-bot facebook-github-bot merged commit 7cf8a5e into pytorch:main Aug 26, 2025
107 of 112 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zonglinpeng zonglinpeng zonglinpeng approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ethansfng @facebook-github-bot @zonglinpeng