Skip to content

Force -O3 for executorch op_div.cpp in "clang 17" also #13660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 4, 2025
Merged

Force -O3 for executorch op_div.cpp in "clang 17" also #13660

merged 1 commit into from
Sep 4, 2025

Conversation

akrieger
Copy link
Contributor

Summary:
Some platforms use clang 19 under the hood but are setting the clang 17
constraint for bad reasons.

Differential Revision: D80980948

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Aug 25, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13660

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 1548bb1 with merge base d7fd78b (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 25, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D80980948

@github-actions GitHub Actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

swolchok
swolchok approved these changes Sep 3, 2025
View reviewed changes
Copy link
Contributor

@swolchok swolchok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as long as it passes OSS CI it seems fine

akrieger added a commit to akrieger/executorch that referenced this pull request Sep 3, 2025
@akrieger @facebook-github-bot
Force -O3 for executorch op_div.cpp in "clang 17" also (pytorch#13660)
312c78a 
Summary:

Some platforms use clang 19 under the hood but are setting the clang 17
constraint for bad reasons.

Reviewed By: swolchok

Differential Revision: D80980948
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D80980948

@akrieger
Force -O3 for executorch op_div.cpp in "clang 17" also (pytorch#13660)
1548bb1 
Summary:
Pull Request resolved: pytorch#13660

Some platforms use clang 19 under the hood but are setting the clang 17
constraint for bad reasons.

Reviewed By: swolchok

Differential Revision: D80980948
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D80980948

@facebook-github-bot facebook-github-bot merged commit aa08df5 into pytorch:main Sep 4, 2025
116 of 118 checks passed
@akrieger akrieger deleted the export-D80980948 branch September 4, 2025 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@swolchok swolchok swolchok approved these changes

@kimishpatel kimishpatel Awaiting requested review from kimishpatel

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@akrieger @facebook-github-bot @swolchok