Skip to content

Qualcomm AI Engine Direct - op enablement sign asin xor floor_divide binary #13675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 26, 2025
Merged

Qualcomm AI Engine Direct - op enablement sign asin xor floor_divide binary #13675

merged 2 commits into from
Aug 26, 2025

Conversation

thchenqti
Copy link
Collaborator

Summary
• Enable sign,asin,xor,floor_divide,binary
• test cases

Test plan
python backends/qualcomm/tests/test_qnn_delegate.py -k TestQNNQuantizedOperators.test_qnn_backend_ -s $DEVICE_SERIAL -m SM8650 -b build-android/
python backends/qualcomm/tests/test_qnn_delegate.py -k TestQNNFloatingPointOperators.test_qnn_backend_ -s $DEVICE_SERIAL -m SM8650 -b build-android/

@thchenqti
op enable sign,asin,xor,binary,floor_divide
78ac40f 
fix_problem_0820

delete floor_div

fix_problem0825
@thchenqti thchenqti requested a review from cccclai as a code owner August 26, 2025 01:51
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Aug 26, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13675

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 60ec02f with merge base 5ff0208 (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

  • pull / test-binary-size-linux-gcc / linux-job (gh) (trunk failure)
    /pytorch/executorch/kernels/portable/cpu/op_stack.cpp:129:26: error: comparison of integer expressions of different signedness: ‘size_t’ {aka ‘long unsigned int’} and ‘ssize_t’ {aka ‘long int’} [-Werror=sign-compare]

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 26, 2025
@github-actions GitHub Actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@cccclai
Copy link
Contributor

cccclai commented Aug 26, 2025

Thank you for enabling so many new ops!

@facebook-github-bot
Copy link
Contributor

@cccclai has imported this pull request. If you are a Meta employee, you can view this in D81051551.

@cccclai cccclai merged commit e5f94da into pytorch:main Aug 26, 2025
110 of 111 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cccclai cccclai cccclai approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thchenqti @cccclai @facebook-github-bot