Skip to content

Remove unused value tags from ObjC ExecuTorchValue #13679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 26, 2025
Merged

Remove unused value tags from ObjC ExecuTorchValue #13679

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
85988e2
Remove unused value tags from ObjC ExecuTorchValue
shoumikhin Aug 26, 2025
08eca72
Remove unused ExecuTorchValueTag cases
shoumikhin Aug 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions extension/apple/ExecuTorch/Exported/ExecuTorchValue.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,6 @@ typedef NS_ENUM(uint32_t, ExecuTorchValueTag) {
ExecuTorchValueTagDouble,
ExecuTorchValueTagInteger,
ExecuTorchValueTagBoolean,
ExecuTorchValueTagBooleanList,
ExecuTorchValueTagDoubleList,
ExecuTorchValueTagIntegerList,
ExecuTorchValueTagTensorList,
ExecuTorchValueTagScalarList,
ExecuTorchValueTagOptionalTensorList,
} NS_SWIFT_NAME(ValueTag);

typedef NSNumber *ExecuTorchScalarValue
Expand Down Expand Up @@ -107,7 +101,7 @@ __attribute__((objc_subclassing_restricted))
*
* @return An float representing the float value.
*/
@property(nonatomic, readonly) ExecuTorchFloatValue floatValue NS_SWIFT_NAME(float);
@property(nonatomic, readonly) ExecuTorchFloatValue floatValue NS_SWIFT_NAME(float);

/**
* Returns YES if the value is of type None.
Expand Down Expand Up @@ -166,7 +160,7 @@ __attribute__((objc_subclassing_restricted))
*
* @return A BOOL indicating whether the value is a float.
*/
@property(nonatomic, readonly) BOOL isFloat;
@property(nonatomic, readonly) BOOL isFloat;

/**
* Creates an instance encapsulating a Tensor.
Expand Down
12 changes: 0 additions & 12 deletions extension/apple/ExecuTorch/Exported/ExecuTorchValue.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,18 +43,6 @@ static inline ExecuTorchValueTag deduceValueTag(NSNumber *number) {
return @"integer";
case ExecuTorchValueTagBoolean:
return @"boolean";
case ExecuTorchValueTagBooleanList:
return @"boolean_list";
case ExecuTorchValueTagDoubleList:
return @"double_list";
case ExecuTorchValueTagIntegerList:
return @"integer_list";
case ExecuTorchValueTagTensorList:
return @"tensor_list";
case ExecuTorchValueTagScalarList:
return @"scalar_list";
case ExecuTorchValueTagOptionalTensorList:
return @"optional_tensor_list";
}
return @"undefined";
}
Expand Down
Loading