Skip to content

Conversation

Erik-Lundell
Copy link
Collaborator

@Erik-Lundell Erik-Lundell commented Aug 27, 2025

Earlier logic partitioned some edge cases that
could not be handled by the backend, and caused small single-constant partitions.

The new logic is more conservative, so some
cases that could be partitioned before might not be anymore. However, the idea is to trade a little less partitioning for more robustness.

Update tests affected by the change.

Also add small dtype debug info to aid with future int64 bug squashing.

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

Earlier logic partitioned some edge cases that
could not be handled by the backend, and caused small
single-constant partitions.

The new logic is more conservative, so some
cases that could be partitioned before might not be
anymore. However, the idea is to trade a little less
partitioning for more robustness.

Update tests affected by the change.

Also add small dtype debug info to aid with future int64
bug squashing.

Signed-off-by: Erik Lundell <erik.lundell@arm.com>
Change-Id: I8199cea8ee802e3213cc8dabc95abd9660f67f35
Copy link

pytorch-bot bot commented Aug 27, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13726

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 5 New Failures, 1 Unrelated Failure

As of commit 505604a with merge base b4e1145 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 27, 2025
@Erik-Lundell Erik-Lundell added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm topic: not user facing ciflow/trunk and removed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Aug 27, 2025
@YufengShi-dudu YufengShi-dudu self-requested a review August 27, 2025 14:26
Copy link
Collaborator

@YufengShi-dudu YufengShi-dudu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved internally

@Erik-Lundell Erik-Lundell added the release notes: none Do not include this in the release notes label Aug 27, 2025
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 27, 2025
@YufengShi-dudu YufengShi-dudu requested a review from zingo August 27, 2025 16:11
@YufengShi-dudu
Copy link
Collaborator

Unrelated failure in unittest-arm-backend-with-no-fvp (test_pytest_ops) / linux-job and test-arm-backend (test_pytest_ops_ethosu_fvp) / linux-job:
backends/arm/test/ops/test_sigmoid_16bit.py::test_sigmoid_tosa_INT_add_sigmoid[ramp] - AttributeError: 'GraphModule' object has no attribute 'output_node'

@zingo
Copy link
Collaborator

zingo commented Aug 27, 2025

Sigmoid error is fixed I triggered a rebase to make sure.

@zingo
Copy link
Collaborator

zingo commented Aug 28, 2025

fails are unrelated to Arm backend

@zingo zingo merged commit 3eb7947 into pytorch:main Aug 28, 2025
239 of 245 checks passed
@Erik-Lundell Erik-Lundell deleted the int64_bug branch September 10, 2025 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes topic: not user facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants