-
Notifications
You must be signed in to change notification settings - Fork 685
Arm backend: Refactor partitioning of int64 #13726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Earlier logic partitioned some edge cases that could not be handled by the backend, and caused small single-constant partitions. The new logic is more conservative, so some cases that could be partitioned before might not be anymore. However, the idea is to trade a little less partitioning for more robustness. Update tests affected by the change. Also add small dtype debug info to aid with future int64 bug squashing. Signed-off-by: Erik Lundell <erik.lundell@arm.com> Change-Id: I8199cea8ee802e3213cc8dabc95abd9660f67f35
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13726
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 5 New Failures, 1 Unrelated FailureAs of commit 505604a with merge base b4e1145 ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved internally
Unrelated failure in unittest-arm-backend-with-no-fvp (test_pytest_ops) / linux-job and test-arm-backend (test_pytest_ops_ethosu_fvp) / linux-job: |
Sigmoid error is fixed I triggered a rebase to make sure. |
fails are unrelated to Arm backend |
Earlier logic partitioned some edge cases that
could not be handled by the backend, and caused small single-constant partitions.
The new logic is more conservative, so some
cases that could be partitioned before might not be anymore. However, the idea is to trade a little less partitioning for more robustness.
Update tests affected by the change.
Also add small dtype debug info to aid with future int64 bug squashing.
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218